Skip to content

Fix the contact form again - #603

Merged
jimmerzzz52 merged 4 commits into
chicagopython:mainfrom
eevelweezel:fix-contact-form
Aug 28, 2025
Merged

jimmerzzz52 merged 4 commits into
chicagopython:mainfrom
eevelweezel:fix-contact-form

Conversation

@eevelweezel

@eevelweezel eevelweezel commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

Fixes #577 ... I hope.

Pretty sure the Crispy Form Helper was automagically overwriting the user-submitted email with the (empty) value from the social auth user profile.

Changes:

  • remove crispy.FormHelper and convert to a regular Django form
  • remove unused dep that angers cython
  • tested locally
  • unit tests are passing
  • screenshot from logs, but others are strongly encouraged to verify:
image

@eevelweezel
eevelweezel marked this pull request as draft August 21, 2025 02:16
@eevelweezel
eevelweezel marked this pull request as ready for review August 21, 2025 02:42
@eevelweezel

Copy link
Copy Markdown
Contributor Author
image

Fixes form formatting.

image

@jimmerzzz52

Copy link
Copy Markdown

LGTM. Nice Tests!

@jimmerzzz52
jimmerzzz52 merged commit 4ab207a into chicagopython:main Aug 28, 2025
3 checks passed
@eevelweezel
eevelweezel deleted the fix-contact-form branch August 28, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contact Form Appears to be Broken

2 participants