chore: compress images and optimize assets#5
Open
niteshmandal0 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @niteshmandal0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant asset optimization effort for the foodjar game module. It involves removing numerous configuration, import, and bundled JavaScript files, indicating a shift in how assets and scripts are managed and delivered, likely to improve loading times and reduce overall package size.
Highlights
- Streamlined Asset Management: The removal of various Cocos Creator-specific asset configuration and import files (config.json, import/*.json) suggests a move towards a more optimized or external asset pipeline.
- Reduced Bundle Size: By removing index.js and other asset-related JSON files, the PR aims to reduce the overall size of the foodjar module, leading to faster load times.
- Improved Performance: The "compress images and optimize assets" title implies that the changes are geared towards enhancing the game's performance by making its resources more efficient.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes a significant number of files related to the 'foodjar' feature, including assets, configuration, and the main JavaScript logic. The title suggests asset optimization, but the scope of deletions points towards a major refactoring or feature removal. The absence of a pull request description makes it impossible to verify the intent and correctness of these changes. It is crucial to update the description to explain why these files are being removed, ensuring the changes can be reviewed effectively and don't introduce regressions.
| @@ -1 +0,0 @@ | |||
| window.__require=function t(e,o,r){function i(a,c){if(!o[a]){if(!e[a]){var s=a.split("/");if(s=s[s.length-1],!e[s]){var l="function"==typeof __require&&__require;if(!c&&l)return l(s,!0);if(n)return n(s,!0);throw new Error("Cannot find module '"+a+"'")}a=s}var d=o[a]={exports:{}};e[a][0].call(d.exports,function(t){return i(e[a][1][t]||t)},d,d.exports,t,e,o,r)}return o[a].exports}for(var n="function"==typeof __require&&__require,a=0;a<r.length;a++)i(r[a]);return i}({equationChoice:[function(t,e,o){"use strict";cc._RF.push(e,"56b73ULfw9L5ZwTSwwHMoYt","equationChoice");var r,i=this&&this.__extends||(r=function(t,e){return(r=Object.setPrototypeOf||{__proto__:[]}instanceof Array&&function(t,e){t.__proto__=e}||function(t,e){for(var o in e)Object.prototype.hasOwnProperty.call(e,o)&&(t[o]=e[o])})(t,e)},function(t,e){function o(){this.constructor=t}r(t,e),t.prototype=null===e?Object.create(e):(o.prototype=e.prototype,new o)}),n=this&&this.__decorate||function(t,e,o,r){var i,n=arguments.length,a=n<3?e:null===r?r=Object.getOwnPropertyDescriptor(e,o):r;if("object"==typeof Reflect&&"function"==typeof Reflect.decorate)a=Reflect.decorate(t,e,o,r);else for(var c=t.length-1;c>=0;c--)(i=t[c])&&(a=(n<3?i(a):n>3?i(e,o,a):i(e,o))||a);return n>3&&a&&Object.defineProperty(e,o,a),a};Object.defineProperty(o,"__esModule",{value:!0});var a=t("../../../common/scripts/drag"),c=cc._decorator,s=c.ccclass,l=c.property,d=function(t){function e(){var e=null!==t&&t.apply(this,arguments)||this;return e.bgNode=null,e}return i(e,t),e.prototype.onTouchEnd=function(e){t.prototype.onTouchEnd.call(this,e),this.isDragging&&(this.match?this.node.emit("equationMatch"):this.node.emit("equationNoMatch"))},n([l(cc.Node)],e.prototype,"bgNode",void 0),n([s],e)}(a.default);o.default=d,cc._RF.pop()},{"../../../common/scripts/drag":void 0}],equationDrop:[function(t,e,o){"use strict";cc._RF.push(e,"c1f45FcFqZJfrhkuJ6ZxTfO","equationDrop");var r,i=this&&this.__extends||(r=function(t,e){return(r=Object.setPrototypeOf||{__proto__:[]}instanceof Array&&function(t,e){t.__proto__=e}||function(t,e){for(var o in e)Object.prototype.hasOwnProperty.call(e,o)&&(t[o]=e[o])})(t,e)},function(t,e){function o(){this.constructor=t}r(t,e),t.prototype=null===e?Object.create(e):(o.prototype=e.prototype,new o)}),n=this&&this.__decorate||function(t,e,o,r){var i,n=arguments.length,a=n<3?e:null===r?r=Object.getOwnPropertyDescriptor(e,o):r;if("object"==typeof Reflect&&"function"==typeof Reflect.decorate)a=Reflect.decorate(t,e,o,r);else for(var c=t.length-1;c>=0;c--)(i=t[c])&&(a=(n<3?i(a):n>3?i(e,o,a):i(e,o))||a);return n>3&&a&&Object.defineProperty(e,o,a),a};Object.defineProperty(o,"__esModule",{value:!0});var a=t("../../../common/scripts/drop"),c=cc._decorator,s=c.ccclass,l=(c.property,function(t){function e(){return null!==t&&t.apply(this,arguments)||this}return i(e,t),n([s],e)}(a.default));o.default=l,cc._RF.pop()},{"../../../common/scripts/drop":void 0}],foodjar:[function(t,e,o){"use strict";cc._RF.push(e,"a6684eBznNCa6ASE01tZ+dS","foodjar");var r,i=this&&this.__extends||(r=function(t,e){return(r=Object.setPrototypeOf||{__proto__:[]}instanceof Array&&function(t,e){t.__proto__=e}||function(t,e){for(var o in e)Object.prototype.hasOwnProperty.call(e,o)&&(t[o]=e[o])})(t,e)},function(t,e){function o(){this.constructor=t}r(t,e),t.prototype=null===e?Object.create(e):(o.prototype=e.prototype,new o)}),n=this&&this.__decorate||function(t,e,o,r){var i,n=arguments.length,a=n<3?e:null===r?r=Object.getOwnPropertyDescriptor(e,o):r;if("object"==typeof Reflect&&"function"==typeof Reflect.decorate)a=Reflect.decorate(t,e,o,r);else for(var c=t.length-1;c>=0;c--)(i=t[c])&&(a=(n<3?i(a):n>3?i(e,o,a):i(e,o))||a);return n>3&&a&&Object.defineProperty(e,o,a),a};Object.defineProperty(o,"__esModule",{value:!0});var a,c,s=t("../../../common/scripts/countingLayout"),l=t("../../../common/scripts/drag"),d=t("../../../common/scripts/game"),u=t("../../../common/scripts/lib/config"),h=t("../../../common/scripts/util"),p=t("../scripts/multLayout"),f=cc._decorator,y=f.ccclass,m=f.property,b=function(){function t(){}return t.prototype.toStringArray=function(){return[this.first.toString(),this.operator,this.second.toString(),"=",this.answer.toString()]},t}();(function(t){t[t.Empty=0]="Empty",t[t.Label=1]="Label",t[t.LabelInCard=2]="LabelInCard",t[t.Objects=3]="Objects",t[t.ObjectsInCard=4]="ObjectsInCard"})(a||(a={})),function(t){t[t.NumbersOnTop=0]="NumbersOnTop",t[t.Mixed=1]="Mixed",t[t.ObjectsOnTop=2]="ObjectsOnTop",t[t.Multiplication=3]="Multiplication"}(c||(c={}));var L=function(t){function e(){var e=null!==t&&t.apply(this,arguments)||this;return e.firstLayout=null,e.secondLayout=null,e.choiceLayout=null,e.equationChoice=null,e.countingLayout=null,e.equationDrop=null,e.equationLabel=null,e.multDrop=null,e.multChoice=null,e.addTexture1=null,e.addTexture2=null,e.addTexture3=null,e.addTexture4=null,e.addTexture5=null,e.addTexture6=null,e.addTexture7=null,e.addTexture8=null,e.addTexture9=null,e.subFullTexture1=null,e.subEmptyTexture1=null,e.subFullTexture2=null,e.subEmptyTexture2=null,e.subFullTexture3=null,e.subEmptyTexture3=null,e.choiceNodes=[],e.problem=new b,e.notSolved=0,e.layoutType=null,e.jars=[],e.firstDrag=null,e.firstDrop=null,e}return i(e,t),e.prototype.onLoad=function(){var t=this;l.default.letDrag=!1,cc.director.getCollisionManager().enabled=!0;var e=u.default.getInstance().data[0],o=(e[0],e[1],e[2],e[3]),r=e[4],i=e[5],n=e[6],a=e[7],s=e[8],d=e[9],p="R"==r?Math.random()<.5?"+":"-":r;"A"==o?parseInt(s)>0?this.layoutType=c.Mixed:this.layoutType=c.NumbersOnTop:this.layoutType="B"==o?c.ObjectsOnTop:c.Multiplication,this.layoutType==c.Multiplication?this.layoutLong(parseInt(i),parseInt(a)):(this.createProblem(parseInt(i),parseInt(n),p,parseInt(d)),this.layoutScreen(o,parseInt(s)),this.choiceNodes.forEach(function(e){t.choiceLayout.addChild(e)})),this.choiceLayout.children.length>5&&(this.choiceLayout.getComponent(cc.Layout).spacingX=10),l.default.letDrag=!0,h.Util.showHelp(this.firstDrag,this.firstDrop)},e.prototype.checkIfDone=function(){var t=this;this.node.emit("correct"),--this.notSolved<=0&&(l.default.letDrag=!1,this.scheduleOnce(function(){t.layoutType==c.Multiplication&&(t.choiceLayout.removeAllChildren(),t.choiceLayout.addChild(t.createLabel(t.problem.first.toString())),t.choiceLayout.addChild(t.createLabel(t.problem.operator)),t.choiceLayout.addChild(t.createLabel(t.problem.second.toString())),t.choiceLayout.addChild(t.createLabel("=")),t.choiceLayout.addChild(t.createLabel(t.problem.answer.toString()))),t.scaleForSpeaking(-1),t.friend.speakEquation(t.problem.toStringArray(),t.scaleForSpeaking.bind(t))},2))},e.prototype.indicateWrongMove=function(){this.node.emit("wrong")},e.prototype.scaleForSpeaking=function(t){var e=this,o=this.secondLayout;this.layoutType==c.NumbersOnTop?o=this.firstLayout:this.layoutType==c.Multiplication&&(o=this.choiceLayout),t>=0&&(o.children[t].scale=1),t+1<o.children.length?o.children[t+1].scale=1.2:(null!=this.friend&&this.friend.playAnimation("jumping",1),(new cc.Tween).target(this.friendPos).to(1,{x:0},null).call(function(){null!=e.friend&&e.friend.playAnimation("eating",1),e.jars.forEach(function(t){var o=t.getComponent(s.default);if(null!=o)null!=e.friend&&o.feed(e.friend.node);else{var r=t.getComponent(p.default);null!=r&&null!=e.friend&&r.feed(e.friend.node)}}),e.firstLayout.parent.removeAllChildren()}).delay(3).call(function(){e.node.emit("nextProblem")}).start())},e.prototype.createEmpty=function(t,e){this.notSolved++;var o=cc.instantiate(this.equationDrop);return o.name=e==a.Label?"L"+t:"O"+t,null==this.firstDrop&&(this.firstDrop=o),o},e.prototype.createLabel=function(t,e){void 0===e&&(e=!1);var o=cc.instantiate(this.equationLabel),r=o.getChildByName("New Label"),i=r.getComponent(cc.Label);return i.string=t,e&&(i.fontSize=60,o.width=r.width),o},e.prototype.createLabelInCard=function(t){return this.createCard("L"+t,this.createLabel(t))},e.prototype.createObjects=function(t,e,o){void 0===e&&(e=0),void 0===o&&(o=-1);var r=cc.instantiate(this.countingLayout),i=r.getComponent(s.default);return this.jars.push(r),i.fullCount=t,0==e&&(e=Math.ceil(9*Math.random())),-1==o?i.fullTexture=this["addTexture"+e]:(i.emptyCount=o,i.fullTexture=this["subFullTexture"+e],i.emptyTexture=this["subEmptyTexture"+e]),r},e.prototype.createObjectsInCard=function(t){return this.createCard("O"+t.toString(),this.createObjects(t))},e.prototype.createCard=function(t,e){var o=this,r=cc.instantiate(this.equationChoice);r.on("equationMatch",function(){o.checkIfDone()}),r.on("equationNoMatch",function(){o.indicateWrongMove()}),r.name=t,r.addChild(e),null!=this.firstDrop&&this.firstDrop.name==t&&null==this.firstDrag&&(this.firstDrag=r);var i=new cc.Node;return i.addChild(r),i.height=r.height,i.width=r.width,i},e.prototype.createLongCard=function(t,e){var o=this;void 0===e&&(e=!0);var r=cc.instantiate(this.multChoice);this.jars.push(r),e?(r.on("equationMatch",function(){o.checkIfDone()}),r.on("equationNoMatch",function(){o.indicateWrongMove()}),null!=this.firstDrop&&this.firstDrop.name==t.toString()&&null==this.firstDrag&&(this.firstDrag=r)):r.getComponent(l.default).allowDrag=!1,r.name=t.toString(),r.getComponent(p.default).count=t;var i=new cc.Node;return i.addChild(r),i.height=r.height,i.width=r.width,i},e.prototype.createLongEmpty=function(t){this.notSolved++;var e=cc.instantiate(this.multDrop);return e.name=t,null==this.firstDrop&&(this.firstDrop=e),e},e.prototype.createProblem=function(t,e,o,r){this.problem.operator=o,this.problem.choices=[],"-"==o&&(e-=1),this.problem.answer=Math.floor(Math.random()*(e-t))+t,"+"==o?(this.problem.answer=Math.floor(Math.random()*(e-t-1))+t+1,this.problem.first=Math.floor(Math.random()*(this.problem.answer-1-t))+t,this.problem.second=this.problem.answer-this.problem.first):"-"==o&&(this.problem.answer=Math.floor(Math.random()*(e-1-t))+t,this.problem.first=Math.floor(Math.random()*(e-this.problem.answer+1))+this.problem.answer+1,this.problem.second=this.problem.first-this.problem.answer),this.problem.choices.push(this.problem.first,this.problem.second,this.problem.answer);for(var i=[],n=t;n<=e;n++)n!=this.problem.answer&&n!=this.problem.first&&n!=this.problem.second&&i.push(n);for(;this.problem.choices.length<=r&&i.length>0;){var a=Math.floor(Math.random()*i.length);this.problem.choices.push(i[a]),i.splice(a,1)}},e.prototype.layoutScreen=function(){var t=this.layoutType==c.NumbersOnTop;if(this.layoutType==c.NumbersOnTop||this.layoutType==c.Mixed){this.addColumn(this.problem.first,t,Math.random()>.5),this.firstLayout.addChild(this.createLabel(this.problem.operator)),this.secondLayout.addChild(this.createLabel(this.problem.operator)),this.addColumn(this.problem.second,t,Math.random()>.5),this.firstLayout.addChild(this.createLabel("=")),this.secondLayout.addChild(this.createLabel("=")),this.addColumn(this.problem.answer,t,Math.random()>.5);for(var e=3;e<this.problem.choices.length;e++)t?this.addToChoicesRandomly(this.createObjectsInCard(this.problem.choices[e])):Math.random()>.5?this.addToChoicesRandomly(this.createObjectsInCard(this.problem.choices[e])):this.addToChoicesRandomly(this.createLabelInCard(this.problem.choices[e].toString()))}else if(this.layoutType==c.ObjectsOnTop){if("+"==this.problem.operator)this.addSumObjects(this.firstLayout,this.problem.first),this.addSumObjects(this.firstLayout,this.problem.second);else{var o=Math.ceil(3*Math.random());if(this.problem.first>10){this.firstLayout.addChild(this.createObjects(10,o,Math.max(0,10-this.problem.answer)));var r=this.problem.first-10;this.firstLayout.addChild(this.createObjects(r,o,Math.min(r,this.problem.second)))}else this.firstLayout.addChild(this.createObjects(this.problem.first,o,this.problem.second))}this.secondLayout.addChild(this.createEmpty(this.problem.first.toString(),a.Label)),this.secondLayout.addChild(this.createEmpty(this.problem.operator,a.Label)),this.secondLayout.addChild(this.createEmpty(this.problem.second.toString(),a.Label)),this.secondLayout.addChild(this.createEmpty("=",a.Label)),this.secondLayout.addChild(this.createEmpty(this.problem.answer.toString(),a.Label)),this.addToChoicesRandomly(this.createLabelInCard(this.problem.first.toString())),this.addToChoicesRandomly(this.createLabelInCard(this.problem.operator.toString())),this.addToChoicesRandomly(this.createLabelInCard(this.problem.second.toString())),this.addToChoicesRandomly(this.createLabelInCard("=")),this.addToChoicesRandomly(this.createLabelInCard(this.problem.answer.toString()))}},e.prototype.addSumObjects=function(t,e){if(e>10){var o=Math.ceil(3*Math.random());t.addChild(this.createObjects(10,o,0)),t.addChild(this.createObjects(e-10,o,0))}else t.addChild(this.createObjects(e))},e.prototype.layoutLong=function(t,e){this.problem.first=t,this.problem.second=e,this.problem.operator="x",this.problem.answer=t*e,this.node.getChildByName("New Layout").removeChild(this.secondLayout),this.firstLayout.height=324,this.choiceLayout.height=324;for(var o=1;o<=e;o++)this.firstLayout.addChild(this.createLongEmpty(t.toString())),o==e?this.firstLayout.addChild(this.createLabel("=",!0)):this.firstLayout.addChild(this.createLabel("+",!0)),this.choiceLayout.addChild(this.createLongCard(t));this.firstLayout.addChild(this.createLongCard(t*e,!1))},e.prototype.addColumn=function(t,e,o){e?(this.firstLayout.addChild(this.createLabel(t.toString())),this.secondLayout.addChild(this.createEmpty(t.toString(),a.Objects)),this.addToChoicesRandomly(this.createObjectsInCard(t))):o?(this.firstLayout.addChild(this.createObjects(t)),this.secondLayout.addChild(this.createEmpty(t.toString(),a.Label)),this.addToChoicesRandomly(this.createLabelInCard(t.toString()))):(this.firstLayout.addChild(this.createEmpty(t.toString(),a.Objects)),this.secondLayout.addChild(this.createLabel(t.toString())),this.addToChoicesRandomly(this.createObjectsInCard(t)))},e.prototype.addToChoicesRandomly=function(t){this.choiceNodes.splice(Math.floor(Math.random()*this.choiceNodes.length),0,t)},n([m(cc.Node)],e.prototype,"firstLayout",void 0),n([m(cc.Node)],e.prototype,"secondLayout",void 0),n([m(cc.Node)],e.prototype,"choiceLayout",void 0),n([m(cc.Prefab)],e.prototype,"equationChoice",void 0),n([m(cc.Prefab)],e.prototype,"countingLayout",void 0),n([m(cc.Prefab)],e.prototype,"equationDrop",void 0),n([m(cc.Prefab)],e.prototype,"equationLabel",void 0),n([m(cc.Prefab)],e.prototype,"multDrop",void 0),n([m(cc.Prefab)],e.prototype,"multChoice",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture1",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture2",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture3",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture4",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture5",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture6",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture7",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture8",void 0),n([m(cc.SpriteFrame)],e.prototype,"addTexture9",void 0),n([m(cc.SpriteFrame)],e.prototype,"subFullTexture1",void 0),n([m(cc.SpriteFrame)],e.prototype,"subEmptyTexture1",void 0),n([m(cc.SpriteFrame)],e.prototype,"subFullTexture2",void 0),n([m(cc.SpriteFrame)],e.prototype,"subEmptyTexture2",void 0),n([m(cc.SpriteFrame)],e.prototype,"subFullTexture3",void 0),n([m(cc.SpriteFrame)],e.prototype,"subEmptyTexture3",void 0),n([y],e)}(d.default);o.default=L,cc._RF.pop()},{"../../../common/scripts/countingLayout":void 0,"../../../common/scripts/drag":void 0,"../../../common/scripts/game":void 0,"../../../common/scripts/lib/config":void 0,"../../../common/scripts/util":void 0,"../scripts/multLayout":"multLayout"}],multLayout:[function(t,e,o){"use strict";cc._RF.push(e,"8d78cWrjR9MGaovV7XxWmV4","multLayout");var r,i=this&&this.__extends||(r=function(t,e){return(r=Object.setPrototypeOf||{__proto__:[]}instanceof Array&&function(t,e){t.__proto__=e}||function(t,e){for(var o in e)Object.prototype.hasOwnProperty.call(e,o)&&(t[o]=e[o])})(t,e)},function(t,e){function o(){this.constructor=t}r(t,e),t.prototype=null===e?Object.create(e):(o.prototype=e.prototype,new o)}),n=this&&this.__decorate||function(t,e,o,r){var i,n=arguments.length,a=n<3?e:null===r?r=Object.getOwnPropertyDescriptor(e,o):r;if("object"==typeof Reflect&&"function"==typeof Reflect.decorate)a=Reflect.decorate(t,e,o,r);else for(var c=t.length-1;c>=0;c--)(i=t[c])&&(a=(n<3?i(a):n>3?i(e,o,a):i(e,o))||a);return n>3&&a&&Object.defineProperty(e,o,a),a};Object.defineProperty(o,"__esModule",{value:!0});var a=cc._decorator,c=a.ccclass,s=a.property,l=function(t){function e(){var e=null!==t&&t.apply(this,arguments)||this;return e.count=0,e.countingSpriteFrame=null,e.objectsLayout=null,e.label=null,e}return i(e,t),e.prototype.onLoad=function(){this.label.string=this.count.toString();var t=this.objectsLayout.getComponent(cc.Layout);this.count>12&&(t.cellSize=cc.size(16,16));for(var e=0;e<this.count;e++){var o=new cc.Node;o.addComponent(cc.Sprite).spriteFrame=this.countingSpriteFrame,this.objectsLayout.addChild(o)}},e.prototype.feed=function(t){var e=t.convertToWorldSpaceAR(cc.Vec2.ZERO);e.y+=200;for(var o=function(){var t=r.objectsLayout.children[r.objectsLayout.childrenCount-1],o=t.convertToWorldSpaceAR(cc.Vec2.ZERO);t.removeFromParent(!0),t.position=o,cc.director.getScene().addChild(t),(new cc.Tween).target(t).to(1,{position:e},null).call(function(){t.active=!1}).start()},r=this;this.objectsLayout.childrenCount>0;)o()},n([s],e.prototype,"count",void 0),n([s(cc.SpriteFrame)],e.prototype,"countingSpriteFrame",void 0),n([s(cc.Node)],e.prototype,"objectsLayout",void 0),n([s(cc.Label)],e.prototype,"label",void 0),n([c],e)}(cc.Component);o.default=l,cc._RF.pop()},{}]},{},["equationChoice","equationDrop","foodjar","multLayout"]); No newline at end of file | |||
There was a problem hiding this comment.
This file appears to contain the bundled application logic for the 'foodjar' feature. Deleting it without any explanation is a critical risk. If this is intentional, the pull request description must explain the reasoning (e.g., feature deprecation, code migration). If this is accidental, this change could lead to a major application failure. Please clarify the purpose of this deletion in the PR description.
| @@ -1 +0,0 @@ | |||
| {"paths":{"0":["textures/foodjar_fridge",2,1],"1":["textures/block_02",2,1],"2":["prefabs/multDrop",0],"3":["textures/foodjar_tiles",2,1],"4":["prefabs/equationLabel",0],"5":["prefabs/equationChoice",0],"6":["textures/foodjar_oven",2,1],"7":["prefabs/equationDrop",0],"8":["prefabs/multChoice",0],"9":["textures/smalljargrey_equation",2,1],"10":["textures/block_01",2,1],"11":["textures/foodjar_cupboard",2,1],"12":["textures/bigjar_equation",2,1],"13":["textures/smalljar_equation",2,1],"14":["prefabs/foodjar",0],"15":["textures/bigjargrey_equation",2,1],"36":["textures/AutoAtlas",1]},"types":["cc.Prefab","cc.SpriteAtlas","cc.SpriteFrame"],"uuids":["06Ykjebq5EGL16US7gou8v","30zlOjuZdA8Ydq9LIHYkBp","37XYYoofBEGIxalYnBjx7K","44/MGwhslI5rBv7srq6Rmb","4enuogTyBLZblXlW0MbgRY","558ydZULBAeKdm4dEVZnSt","7c2TNx9hNC/6oaoJBCKkav","8eD5GD4ZZOxqT1VEZ29Nv5","93rNAUm9hBGJ5A+YJUBa6/","98CHkmm/VFc4OCIjvArfvO","9blYz+zctBeZ5UpRDNAmp3","9fJGOji/tEz5TJuHoB/8Aq","a8BdnLcNRN65HWpA/CTHOo","ddog9CSbNHtYtffIi32tcU","eej2XhR/xI8oPEdmfAIcsz","f1ta4oIj1E8adu3eFQSDfB","08OOcgWF1GSKOdO5zYCffN","14KwpS24dKbKUoB23jeGUm","1b834544f","2e+9XB91FNE7lcj1QX/o1+","34hMFuVHpEQqcn8injzMX5","40GaVVbPxGNYhFL38qNlN0","45bk4jap9A9pnIF9diavwp","46cjH9KYRM0bAPZpqqQCeu","70Tl7PiRFM6YlKoexysEqW","7dkK3Wy6ZI/JL05y2irnkD","7dzgqn9bdIOqW1pSs31oGH","81pl8mT+9P1Y3UPeKtLQ/M","87p944wz5Pe5Y5lxJibtDH","89MGZIY/FCm4Wm8YBevcdX","90foRryRJM3p9AGFGyKh5x","96vzZLo4RPNbnuUaITanQy","9ak/Mk5ztPB6YxchQmON+d","9bvaMerUlDyary99mJa6xp","a89gwQKLpIvoFsdge0XuUf","b7ZyCCSIBLkLvEQ8V8GyQ5","cbCwqzevFERIuQtbgBMKkO","d8HsitJHxOYqo801xBk8ev","ecpdLyjvZBwrvm+cedCcQy","fbO643bHBP1ITGDcPnEYLi"],"scenes":{"db://assets/games/foodjar/scenes/foodjar.fire":28},"redirect":[17,0,19,0,20,0,22,0,23,0,24,0,25,0,26,0,27,0,29,0,31,0,32,0,34,0,35,0,38,1,39,0],"deps":["resources","internal"],"packs":{"05dc5160d":[1,5,10,13],"05f44abf6":[0,16,21,3,4,6,11,14],"0722c41e1":[2,15],"094d0db52":[8,33,12],"0d3f42c90":[18,30,37],"0dee9cfac":[7,9]},"name":"foodjar","importBase":"import","nativeBase":"native","debug":false,"isZip":false,"encrypted":false} No newline at end of file | |||
There was a problem hiding this comment.
The deletion of this main configuration file for the 'foodjar' assets is a high-impact change. It will likely break the 'foodjar' game unless this is part of a feature removal or a migration to a new configuration system. The pull request description should be updated to provide context for this removal to prevent potential production issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.