feat(CHIM-620): migrate navigation and routing to IonReactHashRouter

[manish7321]

What

Migrates app navigation from BrowserRouter/IonReactRouter assumptions to IonReactHashRouter and updates related routing behavior across the app.

This includes:

• moving app routing/content setup into AppContent
• adding hash-aware router location helpers for pathname, search, hash, and URL replacement
• updating history.push / history.replace calls that pass route state so they work correctly with hash routing
• fixing popup navigation and GrowthBook generic popup handling
• updating analytics, logging, auth redirects, and reload flows to read app routes correctly under hash routing
• updating affected tests and router mocks to match the new routing model

Why

The app was being migrated to Ionic hash-based routing, but many flows still assumed browser-style paths and legacy stateful navigation
behavior.

That caused risk of broken or inconsistent:

• route state passing
• popup CTA navigation
• analytics/logging page tracking
• auth redirect behavior
• reload / resume flows
• unit tests that still mocked the old router setup

How

• Replaced the app router setup with IonReactHashRouter and removed the extra top-level BrowserRouter.
• Extracted route/content wiring into AppContent to keep bootstrap simpler while preserving existing overlays, route effects, and hardware back handling.
• Added src/utility/routerLocation.ts to centralize app-aware URL/path handling for both hash and non-hash routing cases.
• Converted stateful navigation calls from history.push(path, state) / history.replace(path, state) to location objects built with parsePath(...) and state, so route state is preserved reliably.
• Updated popup navigation to build replacement URLs correctly for hash routing and fixed popup lifecycle handling by clearing popup-active state before navigation.
• Switched generic popup feature reads to useFeatureValue, broadened popup config typing, and aligned related tests/mocks.
• Preserved important local storage keys during data clearing and updated OAuth redirect handling to respect the app base path.

Testing

• Unit tests
  • Updated router-affected tests and mocks, including App, Home, LiveQuizGame, generic popup navigation/manager, ProfileMenu, StickerBook,
    QRAssignments, and TeacherRecommendedAssignments.

Risks

• Navigation regressions may still exist in less-used flows that depend on route state, query params, or direct window.location assumptions.
• Web login redirect, deep link, popup CTA, and native reload/resume flows are the highest-risk areas because this PR changes URL construction and replacement behavior.
• Broad routing changes touch student, teacher, and ops-console flows, so smoke testing on both web and Android is recommended.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[gemini-code-assist]

Code Review

This pull request refactors the application's routing to support hash-based routing by replacing IonReactRouter and BrowserRouter with IonReactHashRouter, introducing a centralized routerLocation utility to handle pathnames and search parameters, and updating history navigation calls to use parsePath. Feedback on these changes highlights a missing React import in AppContent.tsx, a potential invalid URL construction when appending query parameters in LiveQuizGame.tsx, and an unsafe iteration over localStorage during deletion in DataClear.tsx.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The newly added AppContent component uses React.FC but does not import React. This will cause a TypeScript compilation error (Cannot find name 'React'). Please import React at the top of the file.

import React from 'react';\nimport { IonRouterOutlet } from '@ionic/react';

[gemini-code-assist]

Blindly appending &isReload=false to fromPath can result in an invalid URL path (e.g., /home&isReload=false) if fromPath does not already contain query parameters.\n\nPlease check if fromPath contains ? and use the appropriate separator (? or &) to construct the path, similar to how it is handled in LidoPlayer.tsx.

      const separator = fromPath.includes('?') ? '&' : '?';\n      history.replace({\n        ...parsePath("${fromPath}${separator}isReload=false"),\n        state: returnState,\n      });

[gemini-code-assist]

Iterating backwards over localStorage while calling removeItem can lead to skipped keys or unexpected behavior. According to the HTML Storage specification, the order of keys is implementation-defined and only guaranteed to be consistent as long as the number of keys does not change. Mutating the storage during iteration changes the key indices dynamically.\n\nTo ensure robust and safe deletion, collect all keys into an array first, and then iterate over that array to remove the non-preserved keys.

    const keys: string[] = [];\n    for (let i = 0; i < localStorage.length; i++) {\n      const key = localStorage.key(i);\n      if (key) {\n        keys.push(key);\n      }\n    }\n    for (const key of keys) {\n      if (!KEYS_TO_PRESERVE.has(key)) {\n        localStorage.removeItem(key);\n      }\n    }