Skip to content

removed extra debounce#4705

Open
jagadish-commits wants to merge 4 commits into
devfrom
dev-jagadish-1164
Open

removed extra debounce#4705
jagadish-commits wants to merge 4 commits into
devfrom
dev-jagadish-1164

Conversation

@jagadish-commits

Copy link
Copy Markdown
Collaborator

No description provided.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request optimizes the campaign listing by removing redundant search term debouncing in the frontend and deferring the fetching of campaign details and metrics in the Supabase API. Specifically, if sorting does not require metrics, they are only fetched for the paginated subset of campaigns. Feedback is provided regarding a variable shadowing issue in a catch block within SupabaseApi.ts.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +9881 to +9887
} catch (campaignRowsError) {
logger.error(
'Unexpected error fetching campaign listing detail rows:',
campaignRowsError,
);
return new Map();
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The catch block variable campaignRowsError shadows the campaignRowsError variable declared in the try block (from the Supabase query response). This can lead to confusion and potential linter errors (e.g., @typescript-eslint/no-shadow). Consider renaming the caught exception variable to error or err to distinguish it from the query error.

      } catch (error) {
        logger.error(
          'Unexpected error fetching campaign listing detail rows:',
          error,
        );
        return new Map();
      }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant