removed extra debounce#4705
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Code Review
This pull request optimizes the campaign listing by removing redundant search term debouncing in the frontend and deferring the fetching of campaign details and metrics in the Supabase API. Specifically, if sorting does not require metrics, they are only fetched for the paginated subset of campaigns. Feedback is provided regarding a variable shadowing issue in a catch block within SupabaseApi.ts.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } catch (campaignRowsError) { | ||
| logger.error( | ||
| 'Unexpected error fetching campaign listing detail rows:', | ||
| campaignRowsError, | ||
| ); | ||
| return new Map(); | ||
| } |
There was a problem hiding this comment.
The catch block variable campaignRowsError shadows the campaignRowsError variable declared in the try block (from the Supabase query response). This can lead to confusion and potential linter errors (e.g., @typescript-eslint/no-shadow). Consider renaming the caught exception variable to error or err to distinguish it from the query error.
} catch (error) {
logger.error(
'Unexpected error fetching campaign listing detail rows:',
error,
);
return new Map();
}
No description provided.