Skip to content

fix: update sidebar routing for coordinator pages#4718

Open
Chandu-H-J wants to merge 5 commits into
devfrom
fix/CHIM-1158-ops-sidebar-requests-field-coordinator
Open

fix: update sidebar routing for coordinator pages#4718
Chandu-H-J wants to merge 5 commits into
devfrom
fix/CHIM-1158-ops-sidebar-requests-field-coordinator

Conversation

@Chandu-H-J

Copy link
Copy Markdown
Collaborator

Summary

This PR updates OPS sidebar routing for Field Coordinator users by fixing Dashboard navigation.

Changes

  • Prevented Dashboard from redirecting Field Coordinators to School List.
  • Added Dashboard to the sidebar routing allowlist so it stays on the correct page.
  • Cleaned up the coordinator routing check in SidebarPage.tsx for readability.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the access control logic in SidebarPage.tsx to restrict access to the dashboard, devices, and resources pages based on the field coordinator role. The review feedback correctly identifies a redundant and potentially problematic check where dashboardPath is evaluated both within the request page access block and as a standalone check, and provides a code suggestion to resolve this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/ops-console/pages/SidebarPage.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d59787a178

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ops-console/pages/SidebarPage.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant