Skip to content

Disable Next while submitting on step 4 #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinaypanduga merged 1 commit into from
Jul 16, 2026
Merged

Disable Next while submitting on step 4 #4735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ops-console/components/campaignSetup/CampaignSetupActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ export const CampaignSetupActions: React.FC<CampaignSetupActionsProps> = ({
? !isFormValid || isSubmitting
: activeStep === 1
? !isAssignmentComplete
: false;
: activeStep === 4
? isSubmitting
: false;
Comment on lines 34 to +39

@gemini-code-assist gemini-code-assist Bot Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of adding another level of nested ternary operators to handle activeStep === 4, we can simplify the logic and make it more robust. By applying isSubmitting as a fallback or general condition, we ensure that the primary action button is disabled during submission across all steps, while also keeping the code cleaner and easier to read.

      ? !isFormValid || isSubmitting
      : (activeStep === 1
        ? !isAssignmentComplete
        : false) || isSubmitting;


const handleNextClick = () => {
if (activeStep === 0) {
Expand Down
Loading