Skip to content

CHIM-1187 Preserve school profile selection flow#4738

Merged
vinaypanduga merged 1 commit into
mainfrom
chim-1187-selectmode-school-flow
Jul 16, 2026
Merged

CHIM-1187 Preserve school profile selection flow#4738
vinaypanduga merged 1 commit into
mainfrom
chim-1187-selectmode-school-flow

Conversation

@Chandu-H-J

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve school/kids profile selection when entering SelectMode from explicit user actions.
  • Pass route state from school-mode Switch Profile so SelectMode does not auto-route back to the teacher dashboard.
  • Update SelectMode tests to cover explicit school/profile selection flows while keeping normal teacher restore behavior intact.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fromSchoolModeSwitchProfile flag when navigating from the ProfileMenu to SelectMode. This flag is used to suppress automatic entry into the teacher application for teacher-role users, ensuring they remain in the school selection flow. Corresponding unit tests have been added to verify this behavior. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66665ffcef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pages/SelectMode.tsx
@vinaypanduga
vinaypanduga merged commit a91ec87 into main Jul 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants