Move remaining UI text into string table - #7
Merged
michael-chipmates merged 4 commits intoJul 6, 2026
Conversation
Signed-off-by: Aayush Tiwari <aayushtiwari1001@gmail.com>
String additions change the data hash the fixtures pin. Engine behavior is untouched; the replays are byte-identical apart from the version stamp. Signed-off-by: michael-chipmates <strasserm@chipmates.ai>
Contributor
|
Merged, and thank you: first outside contribution to the project, hours after it went public. The keys are wired exactly right. Your verification notes also handed us a real finding: the golden and validate failures on your Windows checkout point at line-ending normalization mangling our data hashes, and a .gitattributes fix is now on our list. The golden regeneration that rode along is on us (fixtures pin the data hash, so string additions always need a maintainer regen). |
michael-chipmates
marked this pull request as ready for review
July 6, 2026 13:00
Round-four review findings, all closed. Every commit hash cited in docs/BALANCE.md resolves on the published branch (three pre-rewrite orphans replaced), and the deploy script now refuses unpublished hashes. The evidence map's worked example quotes the same METR figure as its table. Pedagogy research reclassified from design to analysis or empirical; two umbrella registry entries dissolved (162 entries); RAND pinned to its topic hub; the status enum drops values no entry used. The cautious preset card says it is hard mode, the title screen says most terms end badly, roadmap gates count what the project can actually count, and the sixth ending keeps its mystery. ADR-003 records the deferred lab-NPC clause; ADR-002 closes its veto window. House typography states its rationale where it is enforced. A stray reference to a private instruction file is gone from the test suite. Signed-off-by: michael-chipmates <strasserm@chipmates.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6.
Verification
pnpm lint— passed with one pre-existing Fast Refresh warning inTagStamp.tsxpnpm typecheck— passedpnpm build— passed after applying a local-only Windows pathname workaround todataRoot(); the workaround is not included in this PRpnpm test— 131 of 138 tests passed; six golden-fixture failures reproduce with the original string table, and the purity-lint subprocess assertion also fails in the local Windows environmentgit diff --check— passedThe repository-wide
pnpm validatebaseline also reports existing generated source/schema files as out of date in this checkout; this change does not modify those generated artifacts.