[sandbox]: Use token-based test path filtering - #144
Merged
ShadowBearVR merged 1 commit intoSep 26, 2026
Merged
Conversation
Replaces hardcoded language-extension suffixes (TEST_FILE_SUFFIXES) and directory lists (TEST_DIRECTORY_NAMES) with unified word-boundary token matching (TEST_PATH_TOKENS) across directory segments and file stems. This accurately identifies test and harness files across any language (such as Rust src/tests.rs, *_tests.*, test_*, *.spec.*, and CamelCase FooTest.* files) without false-matching substrings like 'attest.rs'.
ShadowBearVR
force-pushed
the
test-path-filtering
branch
from
September 25, 2026 19:16
8edb3b4 to
486cfb4
Compare
siemen11
approved these changes
Sep 26, 2026
| # "foo_test.spec" -> ["foo", "test", "spec"] | ||
| # "HTTPTest" -> ["HTTP", "Test"] | ||
| # "dpe_attest" -> ["dpe", "attest"] | ||
| PATH_WORD_TOKEN_RE = re.compile(r"[A-Z]?[a-z]+|[A-Z]+(?=[A-Z]|$)|[0-9]+") |
Collaborator
There was a problem hiding this comment.
Regex the curse of coding: I have less experience here, but maybe double check this one whether we do not miss certain cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #136 and replaces hardcoded language-extension suffixes (TEST_FILE_SUFFIXES) and directory lists (TEST_DIRECTORY_NAMES) with unified word-boundary token matching (TEST_PATH_TOKENS) across directory segments and file stems.
This accurately identifies test and harness files across any language (such as Rust src/tests.rs, _tests., test_, .spec., and CamelCase FooTest. files) without false-matching substrings like 'attest.rs'.