Change build system to scikit-build-core#32
Closed
mdealencar wants to merge 4 commits intochkwon:masterfrom
Closed
Change build system to scikit-build-core#32mdealencar wants to merge 4 commits intochkwon:masterfrom
mdealencar wants to merge 4 commits intochkwon:masterfrom
Conversation
…ad fo LIBRARY for .dll files (CMakeLists.txt)
mdealencar
force-pushed
the
scikit-build
branch
from
a054205 to
9546b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30.
PR #31 is a quick-fix for that issue, but the more robust solution is dropping setup.py entirely and making the build system more robust. There is a caveat though: this PR needs a matching PR to HGS-CVRP to be merged. Currently it is pulling from my fork of HGS-CVRP (hopefully it can be changed to the original repo soon).