Skip to content

Add Fast DU setting - #71

Open
chongfun wants to merge 3 commits into
mainfrom
feature/fast-du-setting
Open

Add Fast DU setting#71
chongfun wants to merge 3 commits into
mainfrom
feature/fast-du-setting

Conversation

@chongfun

@chongfun chongfun commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Pull Request

Verification

Before requesting review, please confirm you have run the appropriate checks:

  • tools/check.sh fmt passed
  • tools/check.sh fast passed (host Clippy and tests)
  • X4 and X3 visual verification passed (if applicable)
  • tools/check.sh emulator passed (emulator tests and goldens)
  • tools/check.sh firmware passed (firmware Clippy and release builds)
  • tools/check.sh all passed (required before the pull request is considered ready)

Skipped checks

If you skipped any checks, please list them below and explain why:

Description

The 0x1C shortcut for fast partial refresh skips per-refresh temperature load and power sequencing. FreeInk made it opt-in after ghosting/blotching reports. Add a "Refresh quality" setting (Normal/Fast) to the settings menu, persisted in AppStateRecord. Normal = stock temperature-compensated sequence. Fast = 0x1C DU shortcut.

@chongfun chongfun self-assigned this Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@chongfun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3751fc7a-d21b-450b-a296-ec2b9f1bedbe

📥 Commits

Reviewing files that changed from the base of the PR and between 32efeb0 and 7463c78.

⛔ Files ignored due to path filters (4)
  • fixtures/golden/landscape-settings-x3.png is excluded by !**/*.png
  • fixtures/golden/landscape-settings.png is excluded by !**/*.png
  • fixtures/golden/settings-type-x3.png is excluded by !**/*.png
  • fixtures/golden/settings-type.png is excluded by !**/*.png
📒 Files selected for processing (12)
  • app-core/src/lib.rs
  • app-core/src/storage_loop.rs
  • display/src/epd/ssd1677.rs
  • fw/src/display_flush/ssd1677.rs
  • fw/src/display_flush/uc8253.rs
  • fw/src/tasks/display.rs
  • proto/src/nvm.rs
  • tools/emulator/src/panel.rs
  • tools/preview/src/main.rs
  • ui/src/app_render.rs
  • ui/src/lib.rs
  • ui/src/render.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

- Swap ssd1677 Fast refresh branches to correctly use 0x1C shortcut
- Safely expand Settings UI to 8 rows by reducing SETTINGS_ROW_STEP
- Revert AppStateRecord to V4 and use reserved byte 31 for compatibility
- Update UI goldens for X4 and X3 targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant