Double entry accounting milestone 1 - #79
Merged
Merged
Conversation
chongfun
force-pushed
the
double_entry_accounting_milestone_1
branch
2 times, most recently
from
August 16, 2026 18:05
1a8375e to
8bef02e
Compare
- Replace legacy RentalProperty, Lease, LeaseTenant, and Tenant with Property, RentableUnit, Tenancy, TenancyParty, Party, PartyAlias, and RentTerm. - Cutover schema via clean single migration db/migrate/20260815000001_core_rental_domain_cutover.rb. - Implement domain services for atomic Property, Tenancy, and RentTerm creation/lifecycle management. - Update routes, controllers, views, queries, and dashboard reports to DaisyUI markup with Hotwire. - Retarget financial models (expenses, scheduled_rents, tenant_payments, tenant_charges, payment_ingestions). - Update RBS types, passing full rbs validation, rubocop, brakeman, and 483/483 RSpec tests with 97.75% line coverage.
chongfun
force-pushed
the
double_entry_accounting_milestone_1
branch
from
August 21, 2026 06:03
8bef02e to
8fe0123
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Milestone 1 of the Rental Domain and Double-Entry Accounting Architecture.
At the end of this milestone, Yanushi must use these core concepts throughout the running application:
This milestone establishes the rental-domain identities and relationships that later accounting milestones will build on.