Double entry accounting milestone 4 - #83
Merged
chongfun merged 2 commits intoAug 24, 2026
Merged
Conversation
…versals - Replace legacy TenantPayment with Receipt model featuring positive amount check constraint, partial unique index on (user_id, payment_method, external_reference), and strict posting immutability - Post balanced Dr Cash / Cr Tenant Receivable journal entries tagged with both tenancy and payer party dimensions - Implement Receipts::CreateService with automatic payer party resolution for single-tenant and guarantor tenancies - Implement Receipts::VoidService and Receipts::CorrectService using row-level locking and accounting reversals dated at original received_on for bookkeeping restatement - Retarget PaymentIngestion to Receipt and update PaymentIngestions::ConfirmService - Update financial queries and Schedule E generator to aggregate from active receipts - Build full ReceiptsController and UI with PDF receipt generation - Remove all legacy TenantPayment models, controllers, views, routes, specs, and RBS definitions
chongfun
force-pushed
the
double_entry_accounting_milestone_4
branch
from
August 21, 2026 06:03
8874ec5 to
1c7fa75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the temporary
TenantPaymentdomain with the permanentReceiptdomain.At the end of this milestone:
A Receipt must preserve:
Tenant balance remains: