Double entry accounting milestone 6 - #85
Merged
chongfun merged 2 commits intoAug 24, 2026
Merged
Conversation
…workflows - Add SecurityDeposit and SecurityDepositTransaction models with immutability and lifecycle guards - Add double-entry posting and balance queries for security_deposits_held liability account - Implement LiabilityTimeline validator enforcing non-negative liability across full timeline - Implement ReceiveService, RefundService, ApplyService, VoidService, and CorrectService - Add concurrency protection and lock ordering (Expense -> SecurityDeposit -> Charge) - Add tenancy dashboard UI, transaction views, correction workflow, and property financial integration - Add RBS type signatures, Rubocop cleanups, unit/request/feature specs with >97% line and >90% branch coverage
chongfun
force-pushed
the
double_entry_accounting_milestone_6
branch
from
August 21, 2026 06:03
492cbf0 to
d940bf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement:
with accounting:
The last operation settles an already-existing Charge. It does not recognize income again.
At the end of the milestone:
Receipts;