First draft of project architecture for central conversion of waveforms#121
Closed
jl1331 wants to merge 2 commits into
Closed
First draft of project architecture for central conversion of waveforms#121jl1331 wants to merge 2 commits into
jl1331 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heavy inspiration was taken from the CHoRUS waveform repo, which originally converts WFDB site data into other file formats. The proposed approach, located in the central_wfs subfolder, takes the opposite direction by converting site data of various formats into WFDB. Therefore, a similar class-based approach can be used to define read and write operations, adapting to both site and file format(s), as well as gap correction. Space is also dedicated for site registry information, which configures specific functions and class methods with additional metadata to be provided in the upcoming site waveform upload. Refer to the README.md for more information on project layout and data flow.