Load mlumr and ggplot2 once per vignette - #114
Conversation
Six vignettes repeated library(mlumr) and library(ggplot2) at the top of the worked example after the setup chunk had already loaded them. The repeat is removed from the precompile sources and the knitted files.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (12)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe pull request removes redundant ChangesVignette package-loading cleanup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The cleanup preserves package availability and paired vignette-source behavior. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the change, reproducibility considerations, and verification results. It does not follow the required template because it omits the Type of Change, Statistical or User-Facing Impact, Documentation, and Checklist sections, and it does not use the required Verification heading or command-and-result block. Resolution Add all required template sections. Select the applicable Type of Change options, state the user-facing and statistical impact, complete the Documentation and Checklist sections, and place the verification commands and results under a Verification heading.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Six vignettes loaded mlumr and ggplot2 twice: once in the setup chunk that also sets
mc.cores, and again at the top of the worked example. The second copy is gone from both the precompile source (.Rmd.orig) and the knitted.Rmd;library()prints nothing, so the knitted output needs no rebuild.No
set.seed()was added: the sampler takesseed = 2026in everymlumr()call, the integration points are an unscrambled Sobol sequence, the survival STC bootstrap is passedseed = 2026, and every chunk that draws random numbers in R already sets the seed directly above it.Checks: one
library(mlumr)per file in all twelve files; the repository checks on vignette currency pass (180 assertions); 28 deletions, no other change.Summary by CodeRabbit