Skip to content

Fix garbled message for multiple commits. Make each one an attachment. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vonbetz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix garbled message for multiple commits. Make each one an attachment. #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions git-slack-hook
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,15 +243,26 @@ function notify() {
fi

# Process the log and escape double quotes; assuming for now that committer names don't have five semicolons in them
log_out=$( git log --pretty=format:"%cN;;;;;${formattedurl}${commitformat}" $countarg ${start}..${end} \
| sed ':a;N;$!ba;s/\n/\\n/g' \
| sed -e 's/\\/\\\\/g' \
| sed -e 's/"/\\"/g' \
| sed -e 's/\(.*\);;;;;\(.*\)/{"title":"\1","value":"\2","short":false},/' )
if $onlylast; then
log_out=$( git log --pretty=format:"%cN;;;;;${formattedurl}${commitformat}" $countarg ${start}..${end} \
| sed ':a;N;$!ba;s/\n/\\n/g' \
| sed -e 's/\\/\\\\/g' \
| sed -e 's/"/\\"/g' \
| sed -e 's/\(.*\);;;;;\(.*\)/{"title":"\1","value":"\2","short":false},/' )
fields=${log_out%?}
attachments="[{ \"fallback\" : \"${header}\", \"color\" : \"good\", \"fields\" : [${fields}]}]"

fields=${log_out%?}
else
log_out=$( git log --pretty=format:"%cN;;;;;${formattedurl}${commitformat}" $countarg ${start}..${end} \
| sed ':a;N;$!ba;s/\n+/\\n/g' \
| sed -e 's/\\/\\\\/g' \
| sed -e 's/"/\\"/g' \
| sed -e 's/\(.*\);;;;;\(.*\)/{ \"fallback\" : \"\", \"color\" : \"good\", \"fields\" : [{"title":"\1","value":"\2","short":false},]},/' \
| sed -e 's/,\]/]/' )

attachments="[${log_out%?}]"
fi

attachments="[{ \"fallback\" : \"${header}\", \"color\" : \"good\", \"fields\" : [${fields}]}]"
fi

if [ -n "${attachments}" ] && [[ "${attachments}" != "" ]]; then
Expand Down