Skip to content

Fix malformed payload when bundeling multiple commits - #36

Open
tabakhase wants to merge 1 commit into
chriseldredge:masterfrom
tabakhase:fix-multicommit
Open

Fix malformed payload when bundeling multiple commits#36
tabakhase wants to merge 1 commit into
chriseldredge:masterfrom
tabakhase:fix-multicommit

Conversation

@tabakhase

Copy link
Copy Markdown

reference to #24 as #27 is not fixing it (using gitweb)
resolves the greedy regex to produce ","short":false}]},&&&&&Tabakhase","value":

(using negative look-around would be cleaner, but does not seem to work there)

@init-js

init-js commented Oct 5, 2016

Copy link
Copy Markdown

that patch doesn't fix the issue either. negating [^;]* does prevent the .* from being greedy, but then any ';' in the preceding field will cause the group to be shorter than it should.

@tabakhase

Copy link
Copy Markdown
Author

Im also not super happy with [^;]* but the best possible (negative look-around didnt work).
Chances of having a ; in the commiters name is quite low tho (but for sure possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants