Conversation
The igniter docs say to include it in mix.exs as:
{:igniter, "~> 0.6", only: [:dev, :test]}
So, when another app pulls in igniter as a dependency in that way and then
also pulls in fyi, it will generate an error when fetching deps.
Changing it to optional: true in fyi fixes this issue. But then we get errors
running something like:
MIX_ENV=prod mix deps.get && MIX_ENV=prod mix compile
So wrapping Mix.Tasks.Fyi.Install in a Code.ensure_loaded?() check to
fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The igniter docs say to include it in mix.exs as:
{:igniter, "~> 0.6", only: [:dev, :test]}So, when another app pulls in igniter as a dependency in that way and then also pulls in fyi, it will generate an error when fetching deps.
Changing it to optional: true in fyi fixes this issue. But then we get errors running something like:
MIX_ENV=prod mix deps.get && MIX_ENV=prod mix compileSo wrapping
Mix.Tasks.Fyi.Installin aCode.ensure_loaded?()check to fix that. Most of the diff is just reformatting due to that.