Refresh workflow docs and project skills#4
Conversation
📝 WalkthroughWalkthroughThis PR establishes comprehensive workflow documentation for WSA Manager, including new Codex review operations and visual baseline debugging procedures, updated artifact validation and UI testing workflows, restructured documentation with archive distinctions, and reinforced PR merge requirements. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines and formalizes the development, testing, and review workflows for the WSA Manager project. It introduces new operational skills, updates existing ones with more precise steps, and clarifies the documentation structure to ensure that current and future contributors have a clear, consistent, and up-to-date source of truth for project processes and guidelines. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request provides a comprehensive update to the project's workflow documentation. It clarifies development processes, organizes documents into 'active' and 'archived' categories, and adds new 'skills' for automated agents. The changes are well-structured and significantly improve the clarity of the project's documentation. I have a couple of suggestions to further improve consistency and long-term maintainability.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.codex/skills/release-check/SKILL.md:
- Around line 17-21: The README.md and SKILL.md require a release asset named
`WSA.Manager.portable.<tag>.zip` but the build config in package.json only
defines electron-builder targets `nsis` and `dir`, so the build cannot produce
that portable zip; fix by either adding a portable/zip target to
electron-builder (e.g., include the `portable` or `zip` target in the
`build.targets` section of package.json so `WSA.Manager.portable.<tag>.zip` is
emitted) or by updating README.md and SKILL.md to remove or correct the
`WSA.Manager.portable.<tag>.zip` requirement and align release validation with
the actual `nsis`/`dir` artifacts, and ensure the release-check step references
the updated artifact names.
- Line 15: The SKILL.md documents that
release/WSA.Manager.Setup.<version>.exe.blockmap must be produced but
scripts/check-release-layout.mjs currently doesn't validate it; update the
release layout validator (e.g., the function that enumerates/validates artifacts
in scripts/check-release-layout.mjs, likely named validateReleaseLayout or
similar) to explicitly assert the presence of a file matching the glob/re
pattern release/WSA.Manager.Setup.*.exe.blockmap (use fs or a glob to find a
matching filename), and fail/report a clear error if no such blockmap is found
so the script enforces the SKILL.md requirement.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cb21e5a0-ab48-4f49-a7cf-ad77c359d008
📒 Files selected for processing (12)
.codex/skills/codex-pr-review-ops/SKILL.md.codex/skills/release-check/SKILL.md.codex/skills/ui-smoke/SKILL.md.codex/skills/visual-baseline-debug/SKILL.md.codex/skills/wsa-readiness-debug/SKILL.md.github/pull_request_template.mdAGENTS.mdREADME.mddocs/README.mddocs/archive/WSA_Cleanup_Guide.mddocs/archive/wsa-electron-roadmap.mddocs/archive/wsa_cleanup_apkmirror_cinexplore.ps1
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Validation
npm run validatenpm run smoke:packagednpm run test:visualnpm run devrelease/win-unpacked/WSA Manager.exerelease/WSA.Manager.Setup.<version>.exeCodex review
@codex reviewrequested on this PR, or automatic reviews are enabledUI evidence
Notes
Summary by CodeRabbit