Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@

strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
arch: ['arm64', 'x86_64']

steps:
Expand Down Expand Up @@ -241,7 +241,7 @@
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
arch: ['arm64', 'x86_64']
permissions:
id-token: write
Expand All @@ -256,51 +256,51 @@
packages-dir: ${{ steps.download.outputs.download-path }}

build_windows:
runs-on: windows-2019
runs-on: windows-2022

strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
arch: ['-AWin32', '-Ax64']
python-arch: ['x86', 'x64']
exclude:
- arch: '-AWin32'
python-arch: 'x64'
- arch: '-Ax64'
python-arch: 'x86'

steps:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
architecture: ${{ matrix.python-arch }}
- uses: actions/checkout@v4
with:
fetch-depth: 0
fetch-tags: true
- name: Install dependencies
run: python -m pip install --upgrade build
- name: Build the wheel
run: |
mkdir build
cd build
cmake -DPYTHON_VERSIONS=${{ matrix.python-version }} .. -G "Visual Studio 16 2019" ${{ matrix.arch }}
cmake -DPYTHON_VERSIONS=${{ matrix.python-version }} .. -G "Visual Studio 17 2022" ${{ matrix.arch }}
cmake --build . --config Release
- name: Archive built wheels
uses: actions/upload-artifact@v4
with:
name: windows_${{ matrix.python-arch }}_${{ matrix.python-version }}
path: build/*.whl
if-no-files-found: error

publish_windows:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
if: github.event_name == 'release' && github.event.action == 'created'
needs: [ build_windows ]
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
python-arch: ['x86', 'x64']
permissions:
id-token: write
Expand Down
6 changes: 3 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.5)

project(lameenc C)

Expand Down Expand Up @@ -72,10 +72,10 @@ ExternalProject_Add(lame
ExternalProject_Get_Property(lame BINARY_DIR)
ExternalProject_Get_Property(lame SOURCE_DIR)

option(PYTHON_VERSIONS "Python versions to build" "3.8;3.9;3.10;3.11;3.12;3.13")
option(PYTHON_VERSIONS "Python versions to build" "3.10;3.11;3.12;3.13;3.14")
# New CMake doesn't take the default above for some reason...
if (${PYTHON_VERSIONS} STREQUAL "OFF")
set(PYTHON_VERSIONS "3.7;3.8;3.9;3.10;3.11;3.12;3.13")
set(PYTHON_VERSIONS "3.10;3.11;3.12;3.13;3.14")
endif ()

foreach (Version IN LISTS PYTHON_VERSIONS)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
This library makes it simple to encode PCM data into MP3 without having
to compile any binaries.

Provides binaries in PyPi for Python 3.8+ for Windows, macOS and Linux.
Provides binaries in PyPi for Python 3.10+ for Windows, macOS and Linux.
''',
author='Chris Staite',
author_email='chris@yourdreamnet.co.uk',
Expand Down
Loading