Mission-critical audit fixes: schema/device safety + resilient registry tests#38
Open
christopherkarani wants to merge 1 commit intomainfrom
Open
Mission-critical audit fixes: schema/device safety + resilient registry tests#38christopherkarani wants to merge 1 commit intomainfrom
christopherkarani wants to merge 1 commit intomainfrom
Conversation
- remove unreachable GenerationSchema encoding error path by using non-failable DynamicCodingKey initializers and eliminating impossible throws - harden DeviceCapabilities chip-type sysctl extraction with return-code checks and UTF-8 decoding without deprecated String(cString:) - add schema regression test covering empty property-name encoding/decoding - align DiffusionModelDownloader test compile guard with production trait conditions (CONDUIT_TRAIT_MLX + MLX + Hub) - replace brittle hard-coded registry/provider counts with invariant assertions in model/provider tests and include new provider cases
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceCapabilities.getChipType()sysctl handling and remove deprecated C-string conversionGenerationSchemaencoding error path by switching to non-failable dynamic coding keysDiffusionModelDownloaderTestscompile gating to match production trait conditionsVerification
swift package clean && swift buildswift testNotes
tasks/todo.mdwas intentionally left uncommitted per repo rule for planning docs.