[BUG](test): fix broken default pytest fixtures in conftest.py - #7488
Open
Diwak4r wants to merge 2 commits into
Open
[BUG](test): fix broken default pytest fixtures in conftest.py#7488Diwak4r wants to merge 2 commits into
Diwak4r wants to merge 2 commits into
Conversation
Embedded NUL (\x00) bytes corrupt the FTS5 inverted index tokenizer, causing "fts5: syntax error near" on full-text queries. Strip them at both insertion points: the metadata table and the FTS5 virtual table. Fixes chroma-core#7388 Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
The default test fixture list references three functions (fastapi, async_fastapi, fastapi_persistent) that lack @pytest.fixture() decorators, and references a non-existent "sqlite_fixture" name that should be "sqlite". Without these decorators pytest cannot resolve the fixtures when tests request them by name via filtered_fixture_names(). The sqlite name mismatch similarly causes fixture resolution failures. Fix: - Add @pytest.fixture(scope="function") to fastapi, async_fastapi, and fastapi_persistent - Replace "sqlite_fixture" with "sqlite" in filtered_fixture_names() Closes chromadb/chroma#7395
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #7395
Description
The default test fixture list in had two issues:
These bugs caused fixture 'fastapi' not found and similar errors when running the default local test path.
Fix
Type of Change
Checklist