fix(models): reuse MiniMax key for CN selections and add MiniMax-M3 to cold-start catalog - #111
Open
octo-patch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: CN model selections could not reuse the MiniMax API key, and the cold-start catalog was missing MiniMax-M3.
Changes
lib/public/js/lib/model-config.js):getAuthProviderFromModelProvidernow maps theminimax-cnmodel provider to theminimaxauth provider, alongside the existingopenai-codex,volcengine-plan, andbyteplus-planmappings. Previouslyminimax-cnwas returned unchanged, so credential fields defined only underminimaxwere never surfaced for CN selections andMINIMAX_API_KEYcould not be reused.lib/server/model-catalog-bootstrap.json): addedMiniMax-M3entries for both theminimaxandminimax-cnproviders, matching the existing regional pattern used forMiniMax-M2.7. The bundled catalog previously exposed the CN provider but omittedMiniMax-M3on cold start.tests/frontend/model-config.test.js): assert thatminimax-cnnormalizes tominimaxand that the visible AI field keys forminimax-cnincludeMINIMAX_API_KEY.Checks
npx vitest run tests/frontend/model-config.test.js tests/server/model-catalog-cache.test.js— 16 passed.