Add missing splash loading spinner and fix its extension path - #217
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The splash loading screen requested
loading-icon.svg, a file that never existed. Every popup open loggednet::ERR_FILE_NOT_FOUNDand the spinner rendered empty.pages/popup/public/loading-icon.svg: a 48x48 ring arc, white track and zinc arc, animated by the existinganimate-spinclass.Splash.tsxatpopup/loading-icon.svg, the same way the other popup icons are referenced.Verified with
pnpm build:dist/popup/loading-icon.svgis emitted and the bundle references the new path.ErrorScreenin the same file references a missingerror-icon.svg. Left for a separate change.