Fix source DLL file locking during development#21
Open
petarcrncecIMP wants to merge 1 commit into
Open
Conversation
…inaries Two changes to prevent the source DLL from being locked after loading: 1. Wrap AssemblyDefinition (Mono.Cecil) in a `using` block so the file handle on the original DLL is released immediately after the command rename pass. Previously the handle was held indefinitely, preventing MSBuild from writing to the DLL during rebuild. 2. Skip .dll/.pdb/.exe files in CopyGeneratedFilesBack(). Compiled assemblies never change at runtime, so copying them back to the original folder is unnecessary and can briefly lock the files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssemblyDefinitioninResolveDuplicateMethodby wrapping it in ausingblock. Previously, Mono.Cecil held a file handle on the original DLL indefinitely, preventing MSBuild from rebuilding the plugin without closing AutoCAD..dll/.pdb/.exefiles inCopyGeneratedFilesBack(). Compiled assemblies never change at runtime, so copying them back to the original folder is unnecessary and can briefly lock the files.Problem
When using CadAddinManager to load a plugin DLL, the source DLL often remained locked, forcing developers to close AutoCAD before rebuilding. The lock was intermittent — sometimes lasting seconds, sometimes minutes — because:
AssemblyDefinition.ReadAssembly()opens a file handle that was never released (noDisposecall)CopyGeneratedFilesBack()copied binary files back to the build output folder, touching the original DLLTest plan
🤖 Generated with Claude Code