Repository navigation
Conversation
Codex renders either the compact navigation rail or the classic expanded sidebar depending on its own feature flags, so the injected entry and the panel mount were both lost whenever the rail was not present. - findReferenceButton falls back to the sidebar's Explore/Plugins button - createEntry also recognises the sidebar's .text-fade-truncate label, so rewriting the entry text keeps its icon - findPageMount falls back to the viewport container when there is no rail - mountActivePage and titlebarLeftInset no longer assume a rail exists
… navigation rail is absent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #446
Merges PR #447 from @liar177, preserving the contributor's commit and authorship.
When Codex renders the classic expanded sidebar (\data-app-shell-feature-navigation=false\), the Taskboard entry never mounted and, even when forced, clicking it did nothing — five places in \inject/codex-taskboard.user.js\ hard-depend on \
av[data-app-navigation-rail]\.
The fix keeps the rail as the preferred path with unchanged behavior and only falls back when the rail is absent:
ail: null\
Verification:
ode --check inject/codex-taskboard.user.js\ passes
ode --test test/inject.test.mjs\ 36/36
pm run typecheck\ and \
pm run build:web\ pass
Note: existing fixtures only render the rail form, so the classic fallback branch has no test coverage. That gap is left as-is, matching the contributor's scope.