Skip to content

Improve client list display and add ASCOM status tooltip - #92

Merged
chvvkumar merged 6 commits into
mainfrom
dev
Jan 5, 2026
Merged

Improve client list display and add ASCOM status tooltip#92
chvvkumar merged 6 commits into
mainfrom
dev

Conversation

@chvvkumar

@chvvkumar chvvkumar commented Jan 5, 2026

Copy link
Copy Markdown
Owner

📋 Overview

This pull request enhances the user interface by improving the display of connected clients and adding an informative tooltip for ASCOM status. It modifies the client management logic to show unique clients by IP address with their most recent connection details. Additionally, a new tooltip provides explanations for the ASCOM status directly within the setup page.

🔄 Changes by Category

  • Features:
    • Updated client list handling to display unique clients based on IP address, showing their most recent connection information.
    • Added an informational tooltip for the ASCOM Status field on the setup page, providing explanations.

📊 Analyzed 6 commit(s) | 🕐 Updated: 2026-01-05T01:46:06.914Z | Generated by GitHub Actions


@github-actions github-actions Bot changed the title Dev Improve client list display and add ASCOM status tooltip Jan 5, 2026
Comment thread .github/workflows/build-and-release.yml Dismissed
Comment thread .github/workflows/build-and-release.yml Dismissed
Comment thread .github/workflows/snd.yml Dismissed
Comment thread .github/workflows/snd.yml Outdated
Comment on lines 76 to 106

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 7 months ago

In general, fix this by explicitly specifying a minimal permissions: block for the workflow or for each job, reducing GITHUB_TOKEN to read‑only access (or disabling unused scopes) while still allowing the current steps to succeed.

The best targeted fix here is to add a permissions: block at the workflow root level (just under name: or on:), so it applies to both build and merge jobs. None of the steps require write access to the repository; they only need to read the code (handled by actions/checkout) and use external Docker credentials. Therefore, we can set contents: read and disable everything else by using permissions: read-all. For maximum clarity and least privilege, we can explicitly use permissions: read-all, which is a valid shortcut meaning “all scopes read‑only”. This will satisfy CodeQL by explicitly constraining GITHUB_TOKEN while not changing the existing behavior of the jobs.

Concretely:

  • Edit .github/workflows/snd.yml.
  • Insert a permissions: read-all block near the top, after the on: block (or directly after name:; both are valid, but we’ll put it after on: to keep triggers and permissions grouped).
  • No imports or extra methods are needed; this is pure YAML configuration.
Suggested changeset 1
.github/workflows/snd.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/snd.yml b/.github/workflows/snd.yml
--- a/.github/workflows/snd.yml
+++ b/.github/workflows/snd.yml
@@ -8,6 +8,8 @@
       - '*.md'
       - 'images/**'
 
+permissions: read-all
+
 jobs:
   build:
     name: Build ${{ matrix.platform_tag }}
EOF
@@ -8,6 +8,8 @@
- '*.md'
- 'images/**'

permissions: read-all

jobs:
build:
name: Build ${{ matrix.platform_tag }}
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
@chvvkumar
chvvkumar merged commit eefeeef into main Jan 5, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants