This repository was archived by the owner on Feb 4, 2024. It is now read-only.
Added the possibility to customize the allowed maximum zoom#178
Open
iron-bytes wants to merge 4 commits intochxp82q:masterfrom
Open
Added the possibility to customize the allowed maximum zoom#178iron-bytes wants to merge 4 commits intochxp82q:masterfrom
iron-bytes wants to merge 4 commits intochxp82q:masterfrom
Conversation
This has been brought up by issue chxp82q#174 in the base repo
The Library "barteksc - AndroidPdfViewer" had a zoom limit of 10x (variable MAXIMUM_ZOOM in class "Pinch.java" in said Library) which did not allow to pinch over that value (methid "onScale" in class "DragPinchManager.java"). Nonethless, it was possible to double-tap-to-zoom to any value, even above 10x, causing a poor UX. For this reason, the maximum zoom has been set at 10x with a SeekBar, instead of using an EditText which allowed any value.
The seekbar has values from 0 to 9 to which 1 is added in the PDF's max zoom properties. Hence the default value 4 will produce a 5x maximum zoom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been brought up by issue #174