Choosing the best reconstruction - #27
Merged
Merged
Conversation
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
… compute a validation loss Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Obi-Wan
marked this pull request as ready for review
July 24, 2026 08:05
Collaborator
Author
|
This seems to not cause any regression, and the returned reconstructions seem to be correct. We'll close and merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the returned reconstructions from the
Solverclasses are the latest iterates. This is not ideal, because reconstructions might diverge, and we might want to select reconstructions through other metrics, e.g., reconstruction residual or cross-validation. This PR changes the way that solvers return the best reconstruction, and track the best iterates with respect to reconstruction loss and cross-validation loss. This behavior is modified through a switch calledcriterion, which is added to the algorithm initialization.TODO
SolutionInfoclassAdd or update unittests.Notes
This feature will be used by the
denoisemethod to provide a better reconstruction out of the box.