Skip to content

Choosing the best reconstruction - #27

Merged
Obi-Wan merged 3 commits into
mainfrom
solution_selection
Jul 24, 2026
Merged

Choosing the best reconstruction#27
Obi-Wan merged 3 commits into
mainfrom
solution_selection

Conversation

@Obi-Wan

@Obi-Wan Obi-Wan commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Description

Currently, the returned reconstructions from the Solver classes are the latest iterates. This is not ideal, because reconstructions might diverge, and we might want to select reconstructions through other metrics, e.g., reconstruction residual or cross-validation. This PR changes the way that solvers return the best reconstruction, and track the best iterates with respect to reconstruction loss and cross-validation loss. This behavior is modified through a switch called criterion, which is added to the algorithm initialization.

TODO

  • Implement new feature:
    • Add support in the solver classes for selection criterion
    • Add better metrics tracking in the SolutionInfo class
    • Move parts of the code that might depend on returned solutions to consider the newer metrics
  • Add or update unittests.
  • Add or update docstrings.
  • Add or update documentation.

Notes

This feature will be used by the denoise method to provide a better reconstruction out of the box.

Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
@Obi-Wan Obi-Wan self-assigned this Jul 21, 2026
@Obi-Wan Obi-Wan added the enhancement New feature or request label Jul 21, 2026
@Obi-Wan Obi-Wan added this to the Release 3.0 milestone Jul 21, 2026
Obi-Wan added 2 commits July 22, 2026 15:01
… compute a validation loss

Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
@Obi-Wan
Obi-Wan marked this pull request as ready for review July 24, 2026 08:05
@Obi-Wan

Obi-Wan commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

This seems to not cause any regression, and the returned reconstructions seem to be correct. We'll close and merge now.

@Obi-Wan
Obi-Wan merged commit 215e815 into main Jul 24, 2026
8 checks passed
@Obi-Wan
Obi-Wan deleted the solution_selection branch July 24, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant