feat: added localization support - #27
Open
eugene-lesnov wants to merge 20 commits into
Open
Conversation
* Working secure notes. * For now desktop only because of crypto lib. * Still need to implement view functionality.
* Node crypto is replaced by WebCrypto. * Small optimizations as well.
* View note feature added. * Logger added. * Constants created. * Better event listener found.
* Comments changed. * Readme updated.
* For cipherswami#7 just need to add showEditorPlugin command during activation. * For cipherswami#8 issue seems like from joplin UI rendernig, for now chose a neutral name.
* WSL MF didn't allow me to network fetch additional script files. * Improved input password view. * Closed cipherswami#9.
* Added screenshot files. * Added invalid format error to secureview.
* Will be moving forward with content script format. * Only encryption and decryption, no secure view for now. * Close cipherswami#2, content scipt uses better default renderer. * Close cipherswami#14, no longer using Editor API.
Fix the latest state is not encrypted / decrypted if using undo / redo before doing so (cipherswami#19)
* Added comments to previous commit. * Updated the version in all places accordingly.
* Updated README. * Changed home page URL and removed promo tile. * Fixed mixed indentations as much as possible.
* Rendering is ok but need the original renderer. * Need to add format shift code. * Removed joplin-logger and using logger file.
* Fix: markdownIt now will also render local png files. * Forced format migration added. * Logger is renamed to pluginLogger as the name is used by joplin. * There is bug when you move from secure view to encrypted note. * This is just a POC version, lot of cleaning has to be done, as some UI is vibe coded.
* MarkdownIt was crashing mobile version so, had to remove the png rendering. * Padding is set properly in mobile version as well. * ContentScript is hardcoreded in case of failure to fetch.
* Added confirm box for encryption. * Incorrect password isolated from decryption errors. * Fixed Secure View CSS issues.
* Changed the note format for this. * Using only code fence in content script.
* Tried my level best to avoid RTE. * Added RefreshNoteView back. * Add working JS to dialog boxes.
* RTE bug is patched via hack. * Menu commands replaced with toggle lock for this release. * HTML elements renamed as well as CSS.
* Tag issue: close cipherswami#18. * Password promt focus: close cipherswami#16. * Password additional confirmation: close cipherswami#15. * RTE issue: close cipherswami#21. * Question: close cipherswami#17.
cipherswami
self-requested a review
May 4, 2026 14:51
Owner
|
This is a lot of change, I hope you tested this. I will check this as soon as I get free time. |
Author
|
@cipherswami I am currently using Joplin with a manually built joplin-plugin-secure-notes plugin. So, after about a week (it should be enough to figure out if I broke something), we can talk about the presence/absence of regression.. |
cipherswami
force-pushed
the
main
branch
5 times, most recently
from
August 1, 2026 11:00
0e455fc to
8b7704a
Compare
cipherswami
force-pushed
the
main
branch
14 times, most recently
from
August 1, 2026 16:45
55e4a0e to
4cacc20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for string localization