Skip to content

Update comment in PfChallenge to clarify how it works for multi round SNARKs #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sashafrolov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update comment in PfChallenge to clarify how it works for multi round SNARKs #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ir/term/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,12 @@ pub enum Op {
/// A random value, sampled uniformly and independently of its arguments.
///
/// Takes a name (if deterministically sampled, challenges of different names are sampled
/// differentely) and a field to sample from.
/// differently) and a field to sample from.
///
/// In IR evaluation, we sample deterministically based on a hash of the name.
///
/// In an multi-round SNARK context, we set this based on hashing commitments
/// to the witnesses for previous rounds.
PfChallenge(Box<ChallengeOp>),
/// Requires the input pf element to fit in this many (unsigned) bits.
PfFitsInBits(usize),
Expand Down
Loading