Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the mobile navigation experience in the sidebar by ensuring the navigation drawer closes appropriately on mobile devices. The main changes involve updating the sidebar's transition logic, closing the drawer when a navigation item is clicked on mobile, and ensuring the drawer is closed on initial mount for mobile viewports.
Mobile navigation improvements:
handleNavItemClickmethod to close the sidebar when a navigation item is clicked on screens smaller than 768px, and attached it to navigation item clicks inAppSidebar.vue. [1] [2]left-0/-left-full) instead of transform-based transitions for improved mobile compatibility inAppSidebar.vue.onMountedlifecycle hook inuseMobileNav.ts.… mount