fix: verify Circle webhook signature against raw request body - #34
Open
mertcano wants to merge 1 commit into
Open
fix: verify Circle webhook signature against raw request body#34mertcano wants to merge 1 commit into
mertcano wants to merge 1 commit into
Conversation
Similar to the recent fix in arc-p2p-payments, this prevents signature validation failures caused by re-serializing the JSON payload. The webhook handler currently parses the request body and runs `JSON.stringify()` before verifying the signature. Since the re-serialized string is not guaranteed to be byte-for-byte identical to the original payload, valid webhooks can randomly get rejected. This updates the handler to use `req.text()` for the cryptographic check and only parses the JSON after the signature is proven valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the recent fix in arc-p2p-payments, this prevents signature validation failures caused by re-serializing the JSON payload.
The webhook handler currently parses the request body and runs
JSON.stringify()before verifying the signature. Since the re-serialized string is not guaranteed to be byte-for-byte identical to the original payload, valid webhooks can randomly get rejected.This updates the handler to use
req.text()for the cryptographic check and only parses the JSON after the signature is proven valid.