fix: validate full amount string before parsing - #39
Open
AtakanGs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #38 by validating the entire normalized amount string before converting it to a number.
parseFloat()accepts a valid numeric prefix and ignores trailing invalid characters, so inputs such as10abcor1.25xyzwere previously accepted as10and1.25.This change:
parseFloat()toNumber()after validationBehavior
Valid examples continue to work:
$1,234.56→1234.561,234.56→1234.561.25→1.25.5→0.5Malformed values are now rejected:
10abc1.25xyz5USDCxTesting
The repository does not currently include a test script/framework for this utility, so I verified the parsing behavior directly with Node and also ran
git diff --checksuccessfully.Closes #38.