Update php and Symfony#1
Merged
Merged
Conversation
Upgrade symfony to at least 7.4 to get the addCommand function (instead of the deprecated add).
Contributor
Author
|
@sunkan What do you think about this? |
sunkan
requested changes
Jun 11, 2026
| "require": { | ||
| "php": "^8.1", | ||
| "symfony/console": "^5.0 || ^6.0 || ^7.0" | ||
| "php": "^8.5", |
Contributor
There was a problem hiding this comment.
Since your changes actually just need 8.2 maybe just bump to 8.2
Contributor
Author
There was a problem hiding this comment.
Yea, was wondering about that, lowered to 8.2
Contributor
|
@runar-stefna |
Allow for broader support of php versions since php 8.5 is not strictly needed yet
sunkan
requested changes
Jun 11, 2026
| - "8.5" | ||
| experimental: | ||
| - false | ||
| include: |
Contributor
There was a problem hiding this comment.
Should be kept and point to 8.6
this is for testing against next php version
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^10.0", | ||
| "phpunit/phpunit": "^12.0", |
Contributor
There was a problem hiding this comment.
do ^11.0 || 12.0 so the test passes
sunkan
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the minimum version of Symfony to 7.4, since that version introduced the
addCommandmethod on theApplicationclass and marked theaddas deprecated.