Skip to content

add more size & type checks to C fasl reader #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
burgerrg wants to merge 5 commits into
base: main
Choose a base branch
from
+98 −59
Open

add more size & type checks to C fasl reader #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f543ba
clean up uptrin uses and guard allocators in alloc.c
burgerrg Apr 15, 2026
c1d6732
more type checks and error message updates
burgerrg Apr 16, 2026
11a1d41
better size checks for gzip & lz4
burgerrg Apr 16, 2026
312697a
more consistent error messages, handle empty fasl_type_begin
burgerrg Apr 16, 2026
1983039
update expected errors
burgerrg Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions c/alloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,16 +799,21 @@ ptr S_null_immutable_string(void) {
}

static ptr stencil_vector(uptr type, uptr mask) {
ptr tc;
ptr p; iptr d;
iptr n = Spopcount(mask);
ptr tc;
ptr p;
iptr d;
iptr n;

tc = get_thread_context();
if (mask >= ((uptr)1 << stencil_vector_mask_bits))
S_error("", "invalid stencil vector mask request");

d = size_stencil_vector(n);
newspace_find_room(tc, type_typed_object, d, p);
VECTTYPE(p) = (mask << stencil_vector_mask_offset) | type;
return p;
n = Spopcount(mask);
tc = get_thread_context();

d = size_stencil_vector(n);
newspace_find_room(tc, type_typed_object, d, p);
VECTTYPE(p) = (mask << stencil_vector_mask_offset) | type;
return p;
}

ptr S_stencil_vector(uptr mask) {
Expand Down Expand Up @@ -1088,6 +1093,9 @@ ptr S_bignum(ptr tc, iptr n, IBOOL sign) {
ptr S_code(ptr tc, iptr type, iptr n) {
ptr p; iptr d;

if ((uptr)n > (uptr)most_positive_fixnum)
S_error("", "invalid code size request");

d = size_code(n);
find_room(tc, space_code, 0, type_typed_object, d, p);
CODETYPE(p) = type;
Expand All @@ -1103,6 +1111,9 @@ ptr S_relocation_table(iptr n) {
ptr tc = get_thread_context();
ptr p; iptr d;

if ((uptr)n > (uptr)most_positive_fixnum)
S_error("", "invalid relocation table size request");

d = size_reloc_table(n);
newspace_find_room(tc, type_untyped, d, p);
RELOCSIZE(p) = n;
Expand Down
Loading