eagerly close file port when open-source-file fails on a non-seekable device#1036
Merged
eagerly close file port when open-source-file fails on a non-seekable device#1036
Conversation
mflatt
approved these changes
Apr 16, 2026
Contributor
mflatt
left a comment
mflatt
left a comment
There was a problem hiding this comment.
It's a worrying that open-source-file is currently not tested at all, but adding a portable test for this change would be a little painful (maybe more than it's worth), anyway. I can't see or detect any problem.
Contributor
Author
|
That's exactly what I thought, and I'm satisfied with a code review and testing it manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1031