Skip to content

Fix printf format specifiers which cause issues on Windows#806

Merged
pabuhler merged 1 commit into
cisco:2_x_devfrom
fippo:2_x_fmt_specifiers
Apr 19, 2026
Merged

Fix printf format specifiers which cause issues on Windows#806
pabuhler merged 1 commit into
cisco:2_x_devfrom
fippo:2_x_fmt_specifiers

Conversation

@fippo

@fippo fippo commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

see e.g Firefox, Chromium ran into the same problem:
https://phabricator.services.mozilla.com/D289571

@fippo fippo force-pushed the 2_x_fmt_specifiers branch from 262f3f6 to 0782cb2 Compare April 14, 2026 15:34
@fippo fippo marked this pull request as ready for review April 14, 2026 15:41
@fippo

fippo commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

error gets caught by -Wformat apparently, from Chromium compile attempts:

[3290/83691] CC obj/third_party/libsrtp/libsrtp/srtp.obj
..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe /c ../../third_party/libsrtp/srtp/srtp.c /nologo /showIncludes:user /winsysroot....(too long)
../../third_party/libsrtp/srtp/srtp.c(667,60): error: format specifies type 'unsigned int' but the argument has type 'u_long' (aka 'unsigned long') [-Werror,-Wformat]
  667 |     debug_print(mod_srtp, "cloning stream (SSRC: 0x%08x)", ntohl(ssrc));

@fippo fippo force-pushed the 2_x_fmt_specifiers branch from 0782cb2 to fd20e20 Compare April 14, 2026 15:57
@fippo

fippo commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

(fixed like it is fixed in 3.x, not how Mozilla did it)

@pabuhler pabuhler merged commit 874e3d8 into cisco:2_x_dev Apr 19, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants