Fix printf format specifiers which cause issues on Windows#806
Merged
Conversation
262f3f6 to
0782cb2
Compare
Contributor
Author
|
error gets caught by -Wformat apparently, from Chromium compile attempts: |
see e.g Firefox, Chromium ran into the same problem: https://phabricator.services.mozilla.com/D289571
0782cb2 to
fd20e20
Compare
Contributor
Author
|
(fixed like it is fixed in 3.x, not how Mozilla did it) |
pabuhler
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see e.g Firefox, Chromium ran into the same problem:
https://phabricator.services.mozilla.com/D289571