sframe api refactor#84
Merged
Merged
Conversation
k-wasniowski
force-pushed
the
sframe-api
branch
from
b0881f5 to
2f4f853
Compare
bifurcation
requested changes
Mar 13, 2026
bifurcation
left a comment
bifurcation
left a comment
Collaborator
There was a problem hiding this comment.
This looks good, except for (a) unwrap() being a macro not a method, and (b) no #ifdef guards around unwrap().
|
|
||
| // Unwrap a Result<T> in a test context. Throws std::runtime_error on error | ||
| // so doctest can catch and report it. | ||
| #define UNWRAP(expr) \ |
Collaborator
There was a problem hiding this comment.
Let's make this a method on Result<T>. There's no reason it needs to be a macro.
It seems like it would be good to #ifdef guard this so that it is only built when exceptions are enabled. That way if you try to build code with unwrap() without exceptions, you'll get a clean hard failure. Looking at documentation, it seems like #ifdef __cpp_exceptions would work.
Co-authored-by: Richard Barnes <rlb@ipv.sx>
k-wasniowski
force-pushed
the
sframe-api
branch
4 times, most recently
from
9dd1ec2 to
356aa9f
Compare
k-wasniowski
force-pushed
the
sframe-api
branch
from
356aa9f to
13a56b3
Compare
bifurcation
approved these changes
Mar 23, 2026
Collaborator
|
Thanks for the work on this @k-wasniowski ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.