Harden key handling and crypto backend edge cases#88
Merged
Conversation
bifurcation
commented
Apr 27, 2026
k-wasniowski
approved these changes
Apr 28, 2026
Comment on lines
+129
to
+132
| void | ||
| clear_openssl_errors() | ||
| { | ||
| ERR_clear_error(); |
Contributor
There was a problem hiding this comment.
Is it used actually outside of crypto files ? If not, wouldnt it be sufficient to call it directly?
Also ive noticed its also called in boringssl, and there it gets less clear. If method is used outside, maybe we could change the name ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing