Coordinate only and move sub bot-code to track main branch#14
Coordinate only and move sub bot-code to track main branch#14jemcmullin wants to merge 20 commits into
Conversation
jemcmullin
commented
May 7, 2026
- Moved submodule of agessaman meshcore-bot to track Main branch for more updates/less maintenance
- Removed all local command scoring, reverting back to original coordinator approach
- Maintains intercept improvements
- Maintains and improves on Community web view for bot admin visibility of coordination events
- Updated documentation
…ity page with relevant information. Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
This PR shifts coordination logic back to a pure “coordinator decides” model by removing local delivery scoring and replacing it with raw-signal bidding (SNR/RSSI/hops/path) plus a hop-based fallback delay when the coordinator is unreachable. It also updates the community web dashboard to focus on coordination events (bid/assigned/fallback) and updates docs to reflect the new approach.
Changes:
- Removed local delivery scoring + score-based fallback; coordinator now evaluates bids using raw signal/path data.
- Added hop-based fallback timing and updated coordination event publishing for the web viewer.
- Updated/trimmed documentation and command surface (removed
coverage, adjusted repeater diagnostics and dashboard UI).
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates coordination explanation and command list to match coordinator-only scoring model. |
| docs/SCORING_SCENARIOS.md | Removed scoring-scenarios doc (local scoring no longer applies). |
| docs/COMMUNITY_DESIGN.md | Removed local scoring design doc (no longer applicable). |
| config.ini.example | Adjusts example category keys for channels. |
| community/web_viewer_packet_stream.py | Changes coordination event payload/summary to stage/winner/reason/delay fields. |
| community/web_viewer_community_page.py | Revamps dashboard to show recent coordination events and simplified repeater ranking. |
| community/scoring_config.ini | Removed (local scoring config no longer used). |
| community/response_timing.py | New hop-based fallback delay + coordinator-provided delay handling. |
| community/message_interceptor.py | Stops computing local scores; forwards raw signal data and uses new timing fallback. |
| community/coverage_fallback.py | Removed score-based fallback implementation. |
| community/coordinator_scoring.py | Removed local scoring implementation. |
| community/coordinator_client.py | should_respond now returns a response dict; stops treating score as bot-global. |
| community/config.py | Removes ScoringConfig (no longer needed). |
| community/community_core.py | Removes scoring config loading; wires in ResponseTiming. |
| community/commands/toprepeaters_command.py | Replaces scoring-based diagnostics with a fan-in/hops repeater view. |
| community/commands/coverage_command.py | Removed coverage command. |
| community/commands/botstatus_command.py | Removes score/fallback-delay reporting to match new model. |
| CLAUDE.md | Updates architecture/flow notes for coordinator-only scoring + hop fallback. |
Comments suppressed due to low confidence (2)
community/commands/toprepeaters_command.py:10
bot_top_repeatersis documented as a command name/entry point, but the command’s registerednameisNearbyTopRepeaters. If command routing usesname(not justkeywords), users won’t be able to invoke it as documented. Consider settingname = "bot_top_repeaters"(and keeping aliases inkeywords) or adjust the docs to reflect the actual command name.
community/commands/toprepeaters_command.py:89max_linksis assigned but never used. Removing it avoids dead code and keeps the output formatting logic clearer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
…tible with upstream submodule changes Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
|
@cj-vana have had this branch running for awhile to test. It's ready, just need you to Approve given the repo rules. |
1f48180 to
5ae1bc0
Compare