fix bug in embarcadero::partial()#40
Open
jmenblaz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version of the function
partialdoesn't work with Random Intercept BART models. Checking the code of the function the steppd <- pdbart(model, xind = x.vars, levs = lev, pl=FALSE)use the model object (bart,rbart...) itself. However, usingrbartas an input of the step return error:x.train must be a matrix, data.frame, formula, fitted bart model, or dbartsSampler.Changing the input object,
fitobj(created previously) formodelobject works properly for both,bartandrbartmodels.I will check the same for other function (
spartials(), etc) and make the PR then