Skip to content

reset maa_quality_avg#9

Open
FalkF wants to merge 1 commit into
cjcliffe:masterfrom
FalkF:patch-1
Open

reset maa_quality_avg#9
FalkF wants to merge 1 commit into
cjcliffe:masterfrom
FalkF:patch-1

Conversation

@FalkF

@FalkF FalkF commented Apr 29, 2022

Copy link
Copy Markdown

Saw this while trying to port it to TS. :)

@FalkF

FalkF commented Apr 29, 2022

Copy link
Copy Markdown
Author

Oh and parseInt defaults to radix 8, is that what you intended for draft_int?

386: const draft_int = parseInt(draft_float / 10.0);
I think the intention of this line was to set draft_int to draft_float / 10 and floor the value?
The correct way would be to use Math.floor() or Math.round().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant