Put current map and entrance into Data Storage - #58
Open
Brian0255 wants to merge 5 commits into
Open
Conversation
Brian0255
marked this pull request as ready for review
June 26, 2026 08:22
Author
|
Tested this out with the PopTracker pack and it seems to be working well using just the map and entrance ID, so I figure this is ready for review now |
Dragion147
approved these changes
Jun 26, 2026
Dragion147
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks ok, @cjmang any opinions on your end? same ingame check is used (different name) and otherwise its another byte that is being read and a flag being set in datastorage if i see this correctly
Owner
|
Overall seems fine. The only concern I have is I don't think this will work very well for same slot co-op. I don't mind merging this in as is, but it would be nice to handle this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #57
Initially I thought just the map ID would be enough, but it seems like the entrance that gets used on transitions is also needed for some very messy dungeon layouts, where different floors will use the same map ID
I did also change
IN_GAMEtoMAP_IDsince that's what it seems to actually be, but let me know if you'd like that changed, along with anything elseMight want to wait on this a bit until I can verify entrance ID is enough? I figured this is a good proof of concept though