Skip to content

Put current map and entrance into Data Storage - #58

Open
Brian0255 wants to merge 5 commits into
cjmang:gstlafrom
Brian0255:gstla-send-map-entrance
Open

Put current map and entrance into Data Storage#58
Brian0255 wants to merge 5 commits into
cjmang:gstlafrom
Brian0255:gstla-send-map-entrance

Conversation

@Brian0255

Copy link
Copy Markdown

PR for #57

Initially I thought just the map ID would be enough, but it seems like the entrance that gets used on transitions is also needed for some very messy dungeon layouts, where different floors will use the same map ID

I did also change IN_GAME to MAP_ID since that's what it seems to actually be, but let me know if you'd like that changed, along with anything else

Might want to wait on this a bit until I can verify entrance ID is enough? I figured this is a good proof of concept though

@Brian0255
Brian0255 marked this pull request as ready for review June 26, 2026 08:22
@Brian0255

Copy link
Copy Markdown
Author

Tested this out with the PopTracker pack and it seems to be working well using just the map and entrance ID, so I figure this is ready for review now

@Dragion147 Dragion147 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok, @cjmang any opinions on your end? same ingame check is used (different name) and otherwise its another byte that is being read and a flag being set in datastorage if i see this correctly

@cjmang

cjmang commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Overall seems fine. The only concern I have is I don't think this will work very well for same slot co-op. I don't mind merging this in as is, but it would be nice to handle this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants