Apply the Export Desk design to the current Converter#7
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cjocollin
marked this pull request as ready for review
July 22, 2026 05:29
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ad728dea-0705-4c33-9f62-a299d942c485) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Preservation boundary
This PR is intentionally presentation-only. It retains current
mainas the source of truth for codecs, MP5-L v4, workers, conversion/export, stems, AI, cancellation, filenames, metadata values, downloads, player import, playlists, and library saves.It does not merge PR #5 wholesale and excludes its editable filename, Web Audio preview, QA demo fixtures, cancellation/export lifecycle changes, and stem changes.
Validation
MP5-L v3in the compatibility matrix and are unrelated to this five-file UI diff.Production remains unchanged until visual QA on the Vercel preview passes.
Note
Low Risk
Large UI/CSS surface area in the Converter only; conversion, codecs, and export paths are described as unchanged, with main regression risk around mobile stage navigation and existing test IDs.
Overview
Replaces the single-file Converter with the MP5 Export Desk presentation: a Source → Metadata → Export progress model, two-column workspace (main column + sticky output rail), and dedicated styling under
mp5-converter-*.Flow & shell:
ConverterFlowStepscollapses the old five-step pills into three labeled steps with checkmarks and a progress line; it now acceptsmetadataOpenso the metadata step can show as active.ConverterPaneldrives astage(source|metadata|export) ondata-stage, skips straight to export on narrow viewports after load, and drops the separate empty-state card in favor of an inline source drop zone plus a loaded source card.Source: New
ConverterSourceCardshows cover/placeholder, file stats, a downsampled waveform, Replace, and drag-and-drop to swap the file.Metadata:
MetadataEditoris reorganized into Details / Artwork / Lyrics / Content / Advanced tabs (primary fields up front, “More track details” disclosure), with credits/rights/identifiers grouped behind a top-level legal disclosure and CaretDown affordances.Export rail: Format choice is a visible control with codec badges (violet MP5 + cyan verified traits), “Advanced formats” for lab codecs/presets, a Ready to export summary, and consolidated status/progress/cancel—mobile hides the rail during metadata editing and uses summary + Continue to Export instead.
Export, codec, stem, and AI behavior are intended to stay unchanged; this is layout and CSS (large
index.cssaddition plus responsive rules).Reviewed by Cursor Bugbot for commit ac39e88. Bugbot is set up for automated code reviews on this repo. Configure here.