Added flag to import conditional probability table#3
Open
dowobeha wants to merge 3 commits intoclab:masterfrom
Open
Added flag to import conditional probability table#3dowobeha wants to merge 3 commits intoclab:masterfrom
dowobeha wants to merge 3 commits intoclab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: if you run an alignment and export the conditional probability table, then later import that table and use it to align your original parallel corpus, there may be differences in the final alignments. I assume this is due to floating point rounding errors introduced during the import/export cycle. I believe this because when you do the preceding, and then continue by again exporting the table, the newly-exported table exactly matches the originally-exported table. These discrepancies in final alignments could presumably be eliminated if the exported tables stored counts rather than probabilities. However, the ttable class currently clears counts when it performs normalization, so for now I'm going to leave things as they are.