feat: verify death declaration deadline from Guichet source#35
Merged
TommiLindfors merged 1 commit intoMay 25, 2026
Merged
Conversation
Contributor
|
Merged! Outstanding work @HirenGajjar. The standout here is that you caught the schema mismatch in the issue description — the issue suggested ISO 8601 duration format ( Also good reasoning on Six merged PRs. You should have received collaborator invitations (write access) to both repos — check your GitHub notifications if you haven't already. That means you can push branches directly without forking. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Understanding the task
The
data/deadlines/lu/death-declaration-deadline.yamlfile had a placeholder in thetextfield andnullforduration— meaning Clarvia could not tell grieving families how long they have to declare a death. This is one of the most time-sensitive obligations after a loss, so getting it right from an official source is critical.Files read before making any changes
1.
data/deadlines/lu/death-declaration-deadline.yamlThe existing file.
durationwasnull,textwas a placeholder,verification_statuswasdiscovered. Thetriggerwas already correctly set todate_of_death.2.
schemas/v0.1/deadline.schema.jsonRead carefully before writing anything. The
durationfield schema is:This is an object with
valueandunit— not an ISO 8601 string. The issue description suggested usingP1D(ISO 8601 format) but that would fail schema validation immediately. The schema is the source of truth, not the issue description.3.
https://guichet.public.lu/en/citoyens/life-event/famille-education/deces-proche.htmlThe official Luxembourg government source already linked in the file. Under the section "Declaration of death to the local authorities":
This is explicit, unambiguous, and from an official government portal. No interpretation required.
Why
value: 24, unit: hoursand notvalue: 1, unit: daysThe Guichet source uses "24 hours" explicitly — not "1 day" or "next working day". Encoding it as
hourspreserves the precision of the official source. Rounding todayswould lose that specificity and could be misleading for a family trying to understand their actual legal window.Why
exceptions: []The official Guichet source page does not state any exceptions to the 24-hour rule in the section covering the declaration deadline. Encoding exceptions that are not stated in the source would be adding unverified information. Left empty — can be updated if a source-backed exception is found.
Schema compliance note
The issue description suggested ISO 8601 duration format (
P1D). This would failpython3 scripts/validate.pybecause the schema requires an object, not a string. All field values in this PR are confirmed valid againstschemas/v0.1/deadline.schema.jsonbefore committing.Source evidence
Page: https://guichet.public.lu/en/citoyens/life-event/famille-education/deces-proche.html
Section: "Declaration of death to the local authorities"
Exact quote: "The death must be declared within 24 hours to the civil registrar's office in the commune where it occurred."
Changes made
duration:null→{value: 24, unit: hours}text: placeholder → verified human-readable deadline statementverification_status:discovered→structured-from-sourceprovenance.updated_at:2026-05-24provenance.updated_by:HirenGajjarnotes: updated to reflect source and reasoningVerified
python3 scripts/validate.py— passes (8 data files)data/sources/lu/guichet-death-life-event.yamluntouched and verified clean