feat: add trilingual /about page with generateMetadata and footer link#31
Merged
Merged
Conversation
Contributor
|
Reviewed — this is outstanding work @HirenGajjar. The server component decision is exactly right (generateMetadata can't be exported from a client component), and the ARIA labels on every section are consistent with your earlier PR #19. Full trilingual content, legal details correct, governance links all pointing to the right files. Note: there will be a small merge conflict with PR #30 (updates page) since both PRs add a footer link. We'll handle that on our side after merging yours. |
Contributor
|
Merged! Nine PRs now @HirenGajjar. The about page is exactly what the project needed — proper legal identity, governance links, and the server component decision was the right call. First time a contributor has built a full page for Clarvia. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Adds
src/app/[lang]/aboutwith full trilingual support (EN/FR/DE) and updates the footer.What's new
src/app/[lang]/about/page.tsx— new fileA server component (no
"use client") with four sections:src/app/[lang]/sections/FooterSection.tsx— updatedAdded About link to the footer nav array between Home and Share your experience.
Technical decisions
Server component over
"use client": The issue requiresgenerateMetadata()which cannot be exported from a client component. The about page has no client-side interactivity, so a server component is the correct and cleaner choice.langis read fromparamsdirectly, matching thelayout.tsxpattern.generateMetadata(): Page-specific title and description in all three languages, with correct canonical URLs (/en/about,/fr/about,/de/about) and OpenGraph metadata.ARIA: All four sections use
aria-labelledbypointing to theirh2ids. Header matches the ARIA pattern from PR #19.Content: Uses
Gunther(no umlaut) per issue guidance. Legal name isCLARVIA ASBLthroughout.Verified
/en/about,/fr/about,/de/aboutall render correctlynpm run lint— 0 errorsnpm run build— passes, all 3 routes statically generated