clbind: disambiguate apply_and_return on std::unique_ptr#1591
Open
paulapatience wants to merge 1 commit intoclasp-developers:mainfrom
Open
clbind: disambiguate apply_and_return on std::unique_ptr#1591paulapatience wants to merge 1 commit intoclasp-developers:mainfrom
paulapatience wants to merge 1 commit intoclasp-developers:mainfrom
Conversation
Previously, returning a std::unique_ptr from a clbound function would complain about ambiguous partial specializations of apply_and_return, the other one being include/clasp/clbind/apply.h:51.
39b24fc to
0e5a916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, returning a std::unique_ptr from a clbound function would complain about ambiguous partial specializations of apply_and_return, the other one being include/clasp/clbind/apply.h:51.
Things I do not understand:
Why did std::move cause problems? Namely, the following:
Also, what to do about the write_multiple_values call? In some other functions in apply.h, it is commented out and supplemented with the same printf I added — that is where I took the printf from. Is there really something we have to do there, or can we just remove it?
Finally, there might be other functions in apply.h that need to be disambiguated, likely the ones specialized on gctools::smart_ptr and gctools::multiple_values, but I do not understand enough of what is going on to be sure (I tried specializing them all, but that caused duplicate definitions, e.g., at lines 68 and 88).